Windows-build-tools: AppVeyor build issues with 1.4.0

[kittaakos]

Our build started to fail with the 1.4.0 release. The build hangs after downloading the python installer. When I switch back to the 1.3.2 version, then python-2.7.13 is installed. That works.
With the python-2.7.14 installer, it fails.

It could be due to one of the recent AppVeyor default image changes or specific to our configuration. Could you please advise? By the way, if you need help, assistance investigating the problem, let me know.

[pmacn]

I've opened PR #81 for the python installer issue.

[felixrieseberg]

Thanks to @pmacn and @jacobq - they're the true heroes and fixed this. Use [email protected] and you should be good. Sorry for the trouble!

[kittaakos]

Thank you for the fix, I can confirm; AppVeyor works perfectly with 1.4.2.

Does anyone know why the build with node v4.0.0 fails? I have tried to reproduce it on my Windows image using node v4.0.0 but, I was unable to reproduce the failure. Thanks!

$ node --version && npm --version && npm install --ignore-scripts && npm run test
v4.0.0
2.14.2

> [email protected] test C:\Users\kittaakos\dev\windows-build-tools
> standard "src/*.js" && npm run build && mocha


> [email protected] build C:\Users\kittaakos\dev\windows-build-tools
> babel src -d lib

src\compatible.js -> lib\compatible.js
src\constants.js -> lib\constants.js
src\download.js -> lib\download.js
src\environment.js -> lib\environment.js
src\index.js -> lib\index.js
src\install\index.js -> lib\install\index.js
src\install\launch.js -> lib\install\launch.js
src\install\tailer.js -> lib\install\tailer.js
src\utils.js -> lib\utils.js


  DownloadTools
    downloadTools (installer)
Downloaded BuildTools_Full.exe. Saved to C:\Users\kittaakos\.windows-build-tools\BuildTools_Full.exe.
      √ should attempt to download the installer (765ms)

  Environment
    √ should attempt to lauch the environment script
    √ should attempt to lauch the environment script with the add to path variable

  Install - Launch
    √ should attempt to lauch the installer script

  Install - Tailer
    √ should register the location of the logfile
    √ waitForLogFile() should resolve when the logfile exists


  6 passing (796ms)

BTW, please note the typo in in the spec descriptions: lauch -> launch.

[jacobq]

@kittaakos I believe that error is indicating that node 4.x does not understand/support destructuring.
See http://node.green/#ES2015-syntax-destructuring--declarations

Basically, instead of const { x } = { x: 10 } you used to have to do var temp = { x: 10 }; var x = temp.x

const { getWorkDirectory } = require('./get-work-dir')
      ^
SyntaxError: Unexpected token {

When you were trying to reproduce the problem, which branch were you using? The build error you mentioned is on the 2.0 (dev) branch.

[kittaakos]

Thanks, @jacobq! Do you happen to know why didn't it fail on my Windows image although I set my node version to 4.0.0? I would like to understand what was the difference between the AppVeyor node and my environment but apparently, I am missing something. Cheers!

[jacobq]

@kittaakos I think I was editing my comment as you were writing your reply. The difference is most likely due to which revision of the code you were actually testing. AppVeyor was testing a PR for the 2.0 branch, which hit a problem with src\utils\get-build-tools-installer-path.js meanwhile your results show testing of src\utils.js -> lib\utils.js, which suggests to me that you are most likely on a different git branch, e.g. master.

[kittaakos]

Makes sense, that's why I was not finding that module. Thank you for the explanation!

[pronebird]

FYI: VC build tools are pre-installed on Appveyor including Python 2.7 if you use the MSVC 2015 Image or newer. There is no need to use windows-build-tools per se.