Wiki: Search process indicator on empty query

[UnlimitedCookies]

Describe the bug
The search progress bar doesn't stop moving once text has been entered and is cleared.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://docs.requarks.io/releases (or any other wiki.js installation)
2. Type some arbitrary search term (e.g. Linux) into the search box
3. Press enter (Idk if this is really necessary)
4. Clear entered text from the search box
   Note: Clear the text all at once either by using CTRL+Backspace or by selecting the text and deleting it.
5. Observe the "ongoing search" animation whilst the search box is empty
   Also: If you now enter any search term it will always report back "No pages matching your query."

Expected behavior
I expect the search process to stop once the search box is emptied.
Idk if this is just the animation or if there's actually a search ongoing whilst the box is empty.

Further suggestion for enhancing the search
If I click with the mouse into the search box it shouldn't display "No pages matching your query."
Rather something like "Start typing to start a search" - this seems more user-friendly IMO.

Thanks!

[NGPixel]

This is regression bug, it used to show a more friendly message when empty.

[NGPixel]

Fixed by 9e35126fc5bf7255e4bda194322a96d608721b65

[UnlimitedCookies]

@NGPixel I don't think the issue has been solved.

There are two issues still persistent that haven't been fixed.

• [x] 1. Please re-read the steps to reproduce on the issue stated above.

Once you clear the search box the search process still doesn't stop.
Watch the attached Video "1. Bug" for further clarification.

• [ ] 2. Once you enter a search term, clear the box with selection of the text, enter a different search term and clear the box again, if you now enter the term that has been entered first it'll show "No results".
  Watch the attached Video "2. Bug" for further clarification.

Thanks!
Github Wiki.js.zip

[mendiromania]

+1 not fixed

[NGPixel]

Fixed by 144950ea7071a37b1c7e2719bcdec6accbfa7f25

[UnlimitedCookies]

Thanks for the fix!

Altough, I am not quite sure whether this fixes the second bug I pointed out or not.
So does it fix the bug to be seen in the second video that I pointed out above?

[NGPixel]

I wasn't able to reproduce your second bug in the dev version. Once 2.4 is out, open a new ticket if you still experience the bug.

[UnlimitedCookies]

Sounds wonderful! I will try it out as soon as v2.4 drops.

[UnlimitedCookies]

I could still reproduce the second bug on the documentation website. I am assuming docs.requarks.io runs on v2.4

If this is the case then I can say that this issue is not resolved.