Wgpu: `Global<GlobalIdentityHandlerFactory>::drop` is very slow

Created on 1 Jun 2020  路  2Comments  路  Source: gfx-rs/wgpu

Description
Global<GlobalIdentityHandlerFactory>::drop is very slow on master, whereas it was not in the 0.5 release. In particular, the call to gfx_backend_dx12::device::destroy_swapchain takes over 3 seconds on my computer.

From the commit history, this seems to have been introduced in https://github.com/gfx-rs/wgpu/commit/831d908663f232e992baec30aaa5ecd45d148da3

It seems likely that this was a latent issue with gfx_backend_dx12 that only surfaced with that commit, but I'm filing this issue here because I'm not sure what the correct resolution is. All I can say is that 3s seems like an exceedingly long time to free a resource.

Platform
Windows 10

bug

All 2 comments

Thank you for the issue!
3 seconds is not expected there at all. Could be a problem with DX12 backend in particular. I think wgpu is doing the right thing here.

Just tried on master and drop is down to a perfectly unnoticeable 13ms. I suppose it was fixed upstream, so I'm closing this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kvark picture kvark  路  4Comments

rukai picture rukai  路  5Comments

kvark picture kvark  路  3Comments

tuzz picture tuzz  路  4Comments

Wumpf picture Wumpf  路  3Comments