Wemake-python-styleguide: User should not configure anything other than the complexity options

[sobolevn]

We should provide default options for isort and flake8.

Related:

1. https://github.com/gforcada/flake8-isort/issues/63

[sobolevn]

See --append-config option that we can monkey-patch.

[sobolevn]

Closed by a misclick.

[AlwxSin]

That's will force me to not use wps.

This linter is good, very good in comparison with naked flake8 or even with flake8 with plugins. But several rules are very opinionated. And it's good I can disable them, just a few.

[sobolevn]

This is not the point of this issue, I am only talking about configuration options like quotes, max-line-length, isort config and so on.

It is not related to ignore, per-file-ignores or complexity rules.
We also use these settings on literally every project: https://github.com/wemake-services/wemake-python-styleguide/blob/master/setup.cfg#L31-L41

[AlwxSin]

Ah, that's ok =)

[sobolevn]

For isort to work we can patch defaults: https://github.com/timothycrosley/isort/blob/develop/isort/settings.py#L76

It is safe, since any custom defined options will take priority over these values.
And since it is just a dict - it is really easy to do.

If they will change the format (I am quite sure that they won't), we can just fix the version of isort.

The only thing I care about is where should we patch it.
We need to do it before flake8-isort plugin starts to work.

I guess that we should do it in the import time. I hope that flake8 import plugins before they are actually executed.
And flake8 plugin API will help us with defining the right moment.

[sobolevn]

Related: https://gitlab.com/pycqa/flake8/issues/555

[sobolevn]

The obvious problem with patching isort config this way is that it won't work for autoformatter part. isort filename.py won't produce the same results.

I will look into plugin system of isort. Or ugly hacks 🙂

[sobolevn]

I guess we have found a solution: https://github.com/andreoliwa/nitpick

[andreoliwa]

I guess we have found a solution: https://github.com/andreoliwa/nitpick

I'm glad nitpick has a practical use outside my own projects. 🙂
It's still beta and with rough edges though.
Let me know if you find more bugs.