Wee-slack: Better support for muted channels

[scotte]

It would be nice to be able to suppress muted channels completely. I'm aware of the "distracting_channels" settings, but that doesn't prevent /part'ed channels from returning. It would be nice to have a setting where muted channels don't show up at all via wee-slack. This can be a problem with large organizations with chatty general channels.

[scotte]

Ah, and I see distracting_channels doesn't work automatically, it requires:

/slack nodistractions

With that, the specified channels are hidden and don't return.

I'm not exactly sure if distracting_channels and muted channels should have some interaction or not. It seems like there should be, perhaps an option that places muted channels into the distracting channels list by default?

[scotte]

I prototyped this - code is ugly, but the idea seems to work (and solves my particular issue): https://github.com/scotte/wee-slack/commit/ddc669c55c4f699481f5a0dfb2bbe65f74f74fa6

This adds two configuration variables:

• hide_distractions : If "1", then automatically hide distractions when connecting.
• muted_are_distractions : If "1", then add muted channels to the distracting channel list.

Again, this is not merge-ready - there are some ugly hacks (like calling command_nodistractions with obscure args, rather than moving the common bits to it's own method), and some other things might be missing. But it's a working proof-of-concept.

[rawdigits]

I want to clean up this behavior too. I used the distracting_channels stuff a lot.

[rawdigits]

Wee-ng has been merged to mainline and features the new /slack mute command, which mutes and unmutes channels.

[scotte]

@rawdigits Maybe I'm just doing something wrong, but it doesn't look like muted channels are fully implemented. Although the "/slack mute" command does change the channels muted status, it doesn't prevent the channel from updating and showing that there are new messages. There's also this suspicious comment: https://github.com/wee-slack/wee-slack/blob/master/wee_slack.py#L1212 - am I just doing something wrong?

[scotte]

Ah! So while /slack mute doesn't really seem to do anything, distracting channels are working and implemented, just not documented.

1. Use "/slack distracting" or add "server.#channel" in a comma delimited list to plugins.var.python.slack.distracting_channels.
2. Use "/slack nodistractions".

This does pretty much exactly what my earlier hack did. Yay!