Webwhatsapp-wrapper: changes for webwhatsapi/objects/contact.py

[dafner]

• [ ] The language must be English, if you are not fluent in English consider using: https://www.deepl.com/translator if it supports your native language

• [ ] Please check if any other issue already adresses your concerns or if a recent PR is already fixing the mentioned issue

• [ ] Please make sure to format your code, and to mark your code as such, with the provided tools from github (upper right of this box)

• [ ] Note that the pip installation might be behind, so try to fix your issue with a pull from the repo and update to the most recent version

• [ ] Follow the Stackoverflow Guidelines (https://stackoverflow.com/help/how-to-ask) when in need of help

• [ ] Consider posting your question on Stackoverflow if it is a general programming question

• [ ] There will be no support for spamming, or other mischief

• [ ] There will be no support for finding professionals

[dafner]

Hi,
I modified the following file according to my needs in order to get the contact's profile image (afer line 25: self.formatted_name = js_obj["formattedName"]):

if 'shortName' in js_obj: self.short_name = js_obj["shortName"] if 'pushname' in js_obj: self.push_name = js_obj["pushname"] if 'formattedName' in js_obj: self.formatted_name = js_obj["formattedName"] if 'profilePicThumbObj' in js_obj: self.profile_pic = js_obj["profilePicThumbObj"].get('eurl', None)

I think that it's and interesting feture and I hope that you include in the next release.

Also, I found a problem in function get_safe_name.
This function not return the short_name if it's set in the contact profile.

I replaced the following line (line 42 in original file)

name = (self.name or self.push_name or self.formatted_name)

with

name = (self.short_name or self.push_name or self.formatted_name)

Regards

[chriso0710]

Please consider making a PR with your changes.

[dafner]

Hi Christian,

sorry, but i'm new using github.

If you tell me how  I can generate a PR I will do it

Or if  you prefer, you can provide me a link with a tutorial

I have other changes that I maked to the original source that I think
could be include in the proyect

Regards

El 15/6/2018 a las 1:54 a. m., Christian Ott escribió:
>

Please consider making a PR with your changes.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mukulhase/WebWhatsapp-Wrapper/issues/288#issuecomment-397513379,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKPud7cZBv_VLNfEuzRids7A0XAP9aKSks5t8z4BgaJpZM4UoDNA.

--
Daniel Fernández*
Desarrollo de Software*
*Tel.: [phone]
Móvil: [phone]

daniel.[email protected] [e-mail]*

Integrisys S.A. http://www.integri-sys.com/
Mifare
http://www.tu-id.com/firmas/MifareAdvancedPartnetCertificateIntegriSys.pdf
tu-id http://www.tu-id.com/
blippar https://www.blippar.com/es/

[chriso0710]

Check out the great docs at
https://help.github.com/categories/collaborating-with-issues-and-pull-requests/
Thank you!

[brunosoaresds]

A little basic flow that can helps you:

• create a fork of project in the fork button in the top-right of the repository page.
• checkout your fork, make your changes, commit and push it into your fork.
• open this repository page and go to pull request tab page.
• click on text ‘select across forks’
• at the right side, select your fork
• click on create pull request

It’s done!!

[dafner]

Thanks you very much for the info!!!

El 15/6/2018 a las 7:49 p. m., Bruno Soares da Silva escribió:
>

A little basic flow that can helps you:

• create a fork of project in the fork button in the top-right of
  the repository page.
• checkout your fork, make your changes, commit and push it into
  your fork.
• open this repository page and go to pull request tab page.
• click on text ‘select across forks’
• at the right side, select your fork
• click on create pull request

It’s done!!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mukulhase/WebWhatsapp-Wrapper/issues/288#issuecomment-397761201,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKPud23WhkTNxeiwfXT3BT2k-d0f6Vryks5t9DnhgaJpZM4UoDNA.

--
Daniel Fernández*
Desarrollo de Software*
*Tel.: [phone]
Móvil: [phone]

daniel.[email protected] [e-mail]*

Integrisys S.A. http://www.integri-sys.com/
Mifare
http://www.tu-id.com/firmas/MifareAdvancedPartnetCertificateIntegriSys.pdf
tu-id http://www.tu-id.com/
blippar https://www.blippar.com/es/