Webtorrent-desktop: Preferences Window

[ChrisMorrisOrg]

After these issues have been opened: #5, #50, #53. Maybe we should consider putting these features into preferences pane?

[feross]

Agree that we need preferences. But we want to be judicious about what we add so we don't end up like this.

I think a preference for #53 make the most sense to do first.

[ChrisMorrisOrg]

100% agree. Maybe we should discuss here what the primary customisation points will be, when the project matures enough.

[feross]

@ChrisMorrisOrg Want to work on an initial preferences window?

I don't think there should be any UI in the window, but just a preferences menu item like most apps have.

[ungoldman]

@feross you mean like a File > Preferences > type thing?

[feross]

Like this:

[ChrisMorrisOrg]

Sure thing! I'll work on it tonight unless someone else has already started work on it.

[ungoldman]

Not me! I say go for it @ChrisMorrisOrg

[ChrisMorrisOrg]

If nobody has started working on this. I will start working on it now (sorry for the delay).

[karloluis]

Can we get a list of things we know for sure should be on the settings page. All the suggestions seem to be scattered out different tickets.

[grunjol]

Now the subtitle part is almost done I think this should be number 1 priority to do.
I will start with the basic structure based on #144 and will go from there to get a modular but simple solution

PS: assigned the issue to myself, will create a branch and periodically will ask for suggestions/reviews

[grunjol]

Questions to @feross @dcposch all:

• Should this preference be inside its own window or a 'dialog like' window?
• hardcoded preference items (big file with code and definition items) or files based( modular/pluggable config?) defined items?

[feross]

@grunjol I want to move away from the modal approach we have been using. We should use the navigation buttons (back/forward) for this kind of thing.

I would implement this as a view in the renderer. This actually simplifies things a lot because we can avoid IPC through the main process -- the state object already lives in the renderer. We can also avoid managing yet another window in windows.js.

When state.url is set to 'preferences', that view should show up. To start, let's just have one option:

• View/edit the download path

[grunjol]

Great! I will go that way.

[grunjol]

Going with the view in the renderer navigation style, and inspired by atom's settings page this is the first iteration:

Let me know what you think about it. PR, coming soon.

[karloluis]

Looks good to me.

[feross]

This is done now in v0.6.0.