Website: Remove /scripts/js/anchor-4.1.1-min.js

Created on 24 Jun 2020  路  13Comments  路  Source: kubernetes/website

Umbrella issue: https://github.com/kubernetes/website/issues/22024

Remove the /scripts/js/anchor-4.1.1-min.js and the corresponding call in /layouts/partial/head.html#L77.

_In theory_ we now use the anchor.js packaged with Docsy, however in practice this may not be the case 馃槄. You'll want to check the build carefully to ensure that anchor links are being generated for subheaders where we want them (on docs pages), and not where we don't (on index pages, i.e.).

If for some reason we can't remove this file, leave a comment in this issue or in the umbrella explaining what happens and why we can't remove it, then close the issue.

good first issue help wanted kincleanup prioritimportant-longterm

All 13 comments

/kind cleanup
/kind important-longterm
/help-wanted

@celestehorgan: The label(s) kind/important-longterm cannot be applied, because the repository doesn't have them

In response to this:

/kind cleanup
/kind important-longterm
/help-wanted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/priority important-longterm

/label help-wanted

@celestehorgan: The label(s) /label help-wanted cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/label help-wanted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/help

@celestehorgan:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/good-first-issue

@celestehorgan:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sabazubair are you still planning to work on this issue?

@luckyvs1 Hey Lucky! I completed this issue and I am waiting for it to be reviewed.

@sabazubair you closed your PR so it won't be able to be reviewed you probably need to reopen it https://github.com/kubernetes/website/pull/22311 so someone can review it

Oh! Oops. Thanks for letting me know. I'll reopen it now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Dieken picture Dieken  路  4Comments

seokho-son picture seokho-son  路  3Comments

jbeda picture jbeda  路  4Comments

shruthibhaskar picture shruthibhaskar  路  3Comments

gochist picture gochist  路  3Comments