Website: Issue with k8s.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/

[Kubelancer]

This is a Bug Report

indentation issue

Proposed Solution:

Page to Update:
https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/

1.18

fix the page indentation

[neolit123]

/sig cluster-lifecycle docs

hi, can you show which section you think is wrong or maybe provide a screenshot?

[Kubelancer]

/sig cluster-lifecycle docs
Attached screenshots

On Thu, May 14, 2020 at 2:08 AM Lubomir I. Ivanov [e-mail]
wrote:

/sig cluster-lifecycle docs

hi, can you show which section you think is wrong or maybe provide a
screenshot?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/issues/20942#issuecomment-628233340,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APOZLIR7XM35XTVEYIRSKQLRRMAN3ANCNFSM4M7VKYJA
.

[neolit123]

i don't see the attachments, possibly because you replied via email.
try adding them using the GitHub web UI.

[Kubelancer]

[Kubelancer]

Page alignment or indentation not proper looks.

[neolit123]

ok, i can confirm this.

@sftim hi, was this broken by this PR, or maybe something on the hugo side changed recently?
https://github.com/kubernetes/website/pull/20496

[sftim]

maybe something on the hugo side changed recently?

The Hugo upgrade was PR #19907

[sftim]

/kind bug
/priority important-longterm

[sftim]

I've tried to make a work around for this. It looks like tabs shortcodes with code snippets inside them don't play well with {{% capture …%}} shortcodes (see issue #20780).

[jimangel]

@neolit123 @sftim I will take a stab at cleaning this up assuming work isn't currently being done. We might have to adjust the page slightly until capture is removed.
/assign

[sftim]

I can share some WIP in case it helps

[neolit123]

thanks for taking a look @sftim and @jimangel

[jimangel]

I can share some WIP in case it helps

oof, sorry @sftim, I saw this after I opened the PR. That does help! I was scratching my head on some of these bugs. Let me know if you want me to modify my PR to incorporate some of your suggestions or vice versa.

I was poking fun of the page on twitter and felt obligated to _try_ to fix it :smile:

[sftim]

Busy at the moment I'm afraid. Feel free to snarf any bits that look useful.