Website: Why default toleration in DS example k8s.io/docs/concepts/workloads/controllers/daemonset/

Created on 6 Mar 2020 · 7Comments · Source: kubernetes/website

This is a Bug Report

Problem:
The example "Create a DaemonSet" adds a toleration for the "NoSchedule" effect on the master node, I don't understand why. I don't think this is a good default to have in the example.

Proposed Solution:
Remove the toleration from the spec:

    spec:
      tolerations:
      - key: node-role.kubernetes.io/master
        effect: NoSchedule

Page to Update:
https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/#create-a-daemonset

good first issue help wanted languagen prioritbacklog

Source

sam-sla

All 7 comments

That seems like a valid concern.

/priority backlog
/good-first-issue
/language en

sftim on 6 Mar 2020

👍1

@sftim:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

That seems like a valid concern.

/priority backlog
/good-first-issue
/language en

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot on 6 Mar 2020

I see that for https://kubernetes.io/docs/tasks/administer-cluster/running-cloud-controller/ the example is more descriptive, maybe this is the way to go instead of removing the toleration. I can create a PR adding the same comment to the daemonset.yaml

sam-sla on 7 Mar 2020

👍1

@sam-sla is this fixed by PR #19530?