Website: Build against the manifest previously downloaded instead of repository one

Created on 18 Feb 2020  路  7Comments  路  Source: kubeflow/website

Hi,

I have a question about which "file" use to build the google cloud platform deployment.

Shouldn't we use the manifest that we previously downloaded from the github and customized?
I have been doing it like that and it seems to be working. From my interpretation from the built package, it is already configured using our values in the manifest instead of need to configure it again.

What i'm talking about is in the section Customizing your kubeflow deployment in the step three.

Currently in the documentation it is like this 馃憞
Current documentation

But i think it should be like this 馃憞
What i think it should be

Please ignore this if i'm wrong 馃槉

Cheers 馃檹

good first issue kinbug

All 7 comments

Issue-Label Bot is automatically applying the labels:

| Label | Probability |
| ------------- | ------------- |
| kind/feature | 0.71 |

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

Thanks @portellaa You are right. This is a copy-paste error. The line should be as you suggest:

kfctl build -V -f ${CONFIG_FILE}

@sarahmaddox thank you. can i send a PR to fix this?

Yes please :)
/assign @portellaa

@sarahmaddox should i close the issue or is it up to you? 馃槉

@portellaa You can do the honours. :)

A tip for next time: In your PR comment you can add wording like this:

fixes https://github.com/kubeflow/website/issues/1700

And then the bot will mark the issue as fixed when the PR is merged.

thank you @sarahmaddox i did the fix #1700 to refer the link, but i didn't knew about that, i didn't read all the commands that the bot accepts 馃槆

thanks 馃檹

Was this page helpful?
0 / 5 - 0 ratings