Website: Broken link to latest Kubernetes documentation

[sftim]

This is a Bug Report

Problem:
https://v1-15.docs.kubernetes.io/docs/ hyperlinks to the latest documentation, except that the link is actually to https://v1-14.docs.kubernetes.io/docs/ (because the href is null).

(oops!)
Here's the markup:

<div class="content deprecation-warning">
      <h3>
     Kubernetes v1.15
      documentation is no longer actively maintained. The version you are currently viewing is a static snapshot. For up-to-date documentation, see the 
     <a href="">latest version.</a>
      </h3>
    </div>

Proposed Solution:
Fix the link so that it takes readers to https://kubernetes.io/docs/

Pages to Update:
https://v1-15.docs.kubernetes.io/docs/
https://v1-14.docs.kubernetes.io/docs/
https://v1-13.docs.kubernetes.io/docs/

[Bradamant3]

@sftim I can't reproduce -- Chrome on Mac Mojave. Markup on the site looks OK (no null href):

<div class="content deprecation-warning">
        <h3>
            Kubernetes v1.14 
            documentation is no longer actively maintained. The version you are currently viewing is a 
            static snapshot. For up-to-date documentation, see the
            <a href="https://kubernetes.io/docs/home/">latest version.</a>
        </h3>
     </div>

[Bradamant3]

Leaving my previous comment in place, but correcting it. Yup, reproduced. Given it's the latest version minus only one, seems a fairly high priority -- also bc seems likely that if we don't fix it'll repro for the next released version.

[sftim]

/priority important-longterm

[zacharysarah]

I'm able to reproduce as well. It's also reproducible in v1-13, but not in v1-12 or v1-11.

I notice that we introduced a string variable in v1.13, making a hard-coded reference the notable difference between v12 and v13.

[zacharysarah]

Also, compare the difference between 1.13 and 1.14 behavior on the docs/ path:

1. https://v1-14.docs.kubernetes.io/docs/ (no redirect to /docs/home/)

1. https://v1-13.docs.kubernetes.io/docs/ (automatically redirects to /docs/home/)

I mention it because v1.13 behaves correctly but also returns a null href:

<section id="deprecationWarning">
  <main>
    <div class="content deprecation-warning">
      <h3>
     Kubernetes v1.13
      documentation is no longer actively maintained. The version you are currently viewing is a static snapshot. For up-to-date documentation, see the 
     <a href="">latest version.</a>
      </h3>
    </div>
  </main>
</section>

[zacharysarah]

@jimangel I have an intution 🔮 this may involve a fix to line 8 on the same order of fixing line 6:

Kubernetes {{ .Page.Param "version" }}
{{ T "deprecation_warning" }}
<a href="{{ .Site.Params.currentUrl }}">{{ T "latest_version" }}</a>

UPDATE: ...Or more like #12743.

UPDATE: ...Or neither. I'm stumped.

[zacharysarah]

After further testing, I notice one difference: at the fully qualified domain name (FQDN) only — https://v1-13.docs.kubernetes.io — the source populates the href correctly:

<section id="deprecationWarning">
  <main>
    <div class="content deprecation-warning">
      <h3>
     Kubernetes v1.13
      documentation is no longer actively maintained. The version you are currently viewing is a static snapshot. For up-to-date documentation, see the 
     <a href="https://kubernetes.io/docs/home/">latest version.</a>
      </h3>
    </div>
  </main>
</section>

Navigating to other URLs on the site (any URL with a path after the FQDN) shows that the shortcode fails to render/populate the href. For example, https://v1-13.docs.kubernetes.io/docs/home/ renders the null values shown above. ☝️

[zacharysarah]

@rlenferink @kbarnard10 @BenTheElder 👋 Any Hugo thoughts here?

[BenTheElder]

🤔 this does look a lot like https://github.com/gohugoio/hugo/issues/5615

[zacharysarah]

@BenTheElder It does--and https://github.com/gohugoio/hugo/issues/5615 was solved in a release more recent than 0.53. That's a potential avenue for testing as well.

[zacharysarah]

Bingo--upgrading Hugo to 0.57.2 solves it. @BenTheElder re:this thread, Exhibit A! :bowtie:

[BenTheElder]

Excellent :-)

[sftim]

/kind bug

[sftim]

Revised the issue description as v1.16 is now out.