This is a Bug Report
Problem:
Ingress apiVersion is incorrect.
If you try to create an Ingress as indicated in the documentation
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
name: test-ingress
annotations:
nginx.ingress.kubernetes.io/rewrite-target: /
spec:
rules:
- http:
paths:
- path: /testpath
backend:
serviceName: test
servicePort: 80
code you'll get the following error:
´´´
no matches for kind "Ingress" in version "networking.k8s.io/v1beta1"
´´´
Proposed Solution:
Change _apiVersion: networking.k8s.io/v1beta1_ for _apiVersion: extensions/v1beta1_
Page to Update:
https://kubernetes.io/docs/concepts/services-networking/ingress/
Kubernetes version 1.12+
/good-first-issue
/language en
Thanks for bring this issue. @konectia If you like, you are welcomed to create a PR to fix it.
@zhangqx2010:
This request has been marked as suitable for new contributors.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
/good-first-issue
/lang en
Thanks for bring this issue. @konectia If you like, you are welcomed to create PR to fix it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@zhangqx2010 I would like to take this up.
Thanks. Please go ahead.
Just a reminder that please relate this issue after you open the PR.
@zhangqx2010: GitHub didn't allow me to assign the following users: palnabarun.
Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide
In response to this:
/assign @palnabarun
Thanks. Please go ahead.
Just a reminder that please relate this issue after you open the PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
On a further look, I found out that the documentation is indeed correct for Kubernetes v1.14. The Ingress kind is in the extensions/v1beta1 for v1.12 and v1.13, whereas Ingress kind is in networking.k8s.io/v1beta1 for v1.14.
Now, the question is should the v1.14 docs for https://kubernetes.io/docs/concepts/services-networking/ingress/ be updated to explicitly state that it will only work for v1.14 or is it implicitly understood that since you are looking at docs for Kubernetes v1.14, it will only work for that version.
Please provide your inputs.
cc: @zhangqx2010
@palnabarun Thanks for the carefully inspection.
From my view, since the document is already related to version, I don't need to bother to point this out explicitly. Otherwise there will be tons of information like that in the document.
So I think we may leave this one just as what it looks like now.
And I think we may close this issue?@palnabarun @konectia
@zhangqx2010 Yes. Please close this issue.
/close
@zhangqx2010: Closing this issue.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Most helpful comment
On a further look, I found out that the documentation is indeed correct for Kubernetes
v1.14. TheIngresskind is in theextensions/v1beta1forv1.12andv1.13, whereasIngresskind is innetworking.k8s.io/v1beta1forv1.14.Now, the question is should the
v1.14docs forhttps://kubernetes.io/docs/concepts/services-networking/ingress/be updated to explicitly state that it will only work forv1.14or is it implicitly understood that since you are looking at docs for Kubernetesv1.14, it will only work for that version.Please provide your inputs.
cc: @zhangqx2010