Webrender: "Port ps_blend to be a brush shader" regressions

[Darkspirit]

Regression range: https://github.com/servo/webrender/compare/38df48c62c929a3603f3c6e6393c2be8f1c88903...d69bd28a055e2afb2ad234eea297dd45f9b4b4e5 (webrender update)

• [x] [Bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1439059) | tab loading animation is broken (Screencast)

Edit:
Also affected:

• [x] [bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1439083) | https://vuetifyjs.com/en/components/buttons (click on a button, "become a patron" on the top left and on a menu item on the left)
  
  
  
  • [x] Reopened: Black glitch (screencast, about:support)
  
  
• [x] [bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1440087) | http://www.senecacollege.ca/campuses/janelocation.html (click plus/minus to zoom the map)
  
  
  
  • [x] Reopened: Black boxes (screencast)
  
  
• [x] [bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1439257) | https://www.facebook.com/search/str/Firefox/keywords_search (example screenshot)
  
  
  
  • [x] Reopened: Black boxes (screencast)
  
  
• [x] https://web.whatsapp.com (file sending menu; not 100% sure)
• [x] [bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1440158) | Google Calendar animations show junk data (untested; not sure about the regression range, but it sounds similar to the other regressions)
• [x] [bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1440179) | https://www.akamai.com/us/en/cdn/ + this theme = drawn on chrome (screenshot)
  
  
  
  • [x] Reopened: Black stripes (screencast, about:support)
  
  

Edit 2:
It seems that only the tab loading animation and whatsapp's file sending menu(?) are fixed by servo/webrender#2443.

---

Black boxes (Intel Sandybridge Mobile on Linux)

Edit 3:
I can't reproduce them, but the reporter confirmed the same regression range and that they aren't fixed in the try build from #2477.

• [x] [bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1441025) | Byline/date text on humphd.org shows bad text rendering and erroneous black background (screenshot)
  
  
  
  • [x] [bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1442134) | Most of chick-fil-a.com is black (screenshot | expected appearance | wr-capture.7z)
    
    (His forward button is always black and has the same regression range.)
  
  
  • [x] [bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1442386) | Startpage SERP hamburger menu is visually corrupted (screenshot | expected appearance)
  
  

Edit 4:

• [x] [bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1442828) | Google News hamburger menu, search box, app switcher visually corrupted (screenshot)
• [x] from another user: bugzilla | Black boxes on YouTube and around icons (screencast, about:support)

[kvark]

I want all the issues to come in like this :heart_eyes:

[Darkspirit]

WR @ b53cf7799a0f5861dfa928ee0ccc66e8d0b78758 try build

mozregression --repo try --launch d115c4c11850c1b1d0b1c847eefc3d959efe0b12 --pref gfx.webrender.all:true

I can reproduce all remaining issues.

[glennw]

I'll investigate these this week, thanks for the detailed report!

[glennw]

I can repro the akamai bug locally here (even without the theme activated). I'll see if I can narrow that down to a small repro case. Hopefully fixing one of those will get the rest of them, this time.

[glennw]

This https://github.com/servo/webrender/pull/2477 fixes the akamai test case above. I haven't tested against the other cases yet, but I expect it will probably fix them all. I need to do a try run first to see if it breaks anything else.

[glennw]

I tested https://vuetifyjs.com/en/components/buttons and http://www.senecacollege.ca/campuses/janelocation.html with this change, and I didn't see any obvious issues.

[Darkspirit]

mozregression --repo try --launch b6987fdf2f5cad510d74179bb7196829fec1e00e --pref gfx.webrender.all:true

• vuetifyjs buttons + menu are fixed
• gmaps looks mostly fine. I saw another issue when Ctrl+Scrolling on it where my whole UI died. (Yesterday I got a crash at this point. Maybe I ran into this, but I don't know.) I will file a seperate bug about that.
• facebook is fixed

* akamai is fixed

• google calendar was possibly the same as the tab loading issue and is fixed. (Fix range)

---

That webrender update had one more regression: https://bugzilla.mozilla.org/show_bug.cgi?id=1441025
I couldn't reproduce that. (He always had his own special text bugs.) Hopefully that is gone too, but I don't know. (moved to the next comment)

[Darkspirit]

Black boxes

I deleted my previous two comments. Things have been confirmed now:

I can't reproduce them, but the reporter confirmed the same regression range and that they aren't fixed in the try build from #2477.

• bugzilla | Byline/date text on humphd.org shows bad text rendering and erroneous black background (screenshot)
• bugzilla | Most of chick-fil-a.com is black (screenshot | expected appearance | wr-capture.7z)
• His forward button is always black and has the same regression range.
• bugzilla | Startpage SERP hamburger menu is visually corrupted (screenshot | expected appearance)

Edit: Some more reports (which I can't reproduce):

• bugzilla | Google News hamburger menu, search box, app switcher visually corrupted (screenshot)
• from another user: bugzilla | Black boxes on YouTube and around icons (screencast, about:support)

[Darkspirit]

The user who reported these "things are black" regressions still sees issues on already fixed websites:
His screencasts: akamai, gmaps, facebook
His Akamai issue is different from my initial report: Only the outer right part is drawn - in black - on his chrome. Hopefully this makes it easier for you to narrow down the source of this problem.

[Darkspirit]

Both users affected by black glitches have this graphics card: Mesa DRI Intel(R) Sandybridge Mobile

[glennw]

My guess is that Sandybridge drivers don't get updated much anymore, if at all. So we'll probably need to get hold of some hardware with that GPU, and find a workaround for what appears to be a driver bug.

[glennw]

@Darkspirit I think all the remaining issues were related to the Sandybridge GPU only, which is fixed by https://github.com/servo/webrender/pull/2530. Are you fine with closing this one off?

[Darkspirit]

:hourglass: Awaiting confirmation

[Darkspirit]

:sunny: Verified fixed: All Sandybridge issues are gone.