Webpack-encore: Strange code analyzing of webpack.config.js in PhpStorm

[yura3d]

Hi!

I have fresh installation of webpack-encore-bundle and it works fine, but I see some strange things when I open webpack.config.js in PhpStorm.

Some methods of Encore object (like isRuntimeEnvironmentConfigured(), configureRuntimeEnvironment(), setOutputPath()) are highlighted as unresolved, but some others (setPublicPath(), addEntry()) are resolved correctly:

The strangest thing is that if I swap setOutputPath() and setPublicPath(), so after that setPublicPath() becomes unresolved (was resolved) and setOutputPath() is resolved (was unresolved):

Windows 10 x64 1909
PhpStorm 2020.2 (JavaScript version is set to ECMAScript 6+ in settings)
Node.JS 14.7.0
Installed devDependencies:

"@symfony/webpack-encore": "^0.30.0",
"core-js": "^3.0.0",
"regenerator-runtime": "^0.13.2",
"webpack-notifier": "^1.6.0"

This issue is very similar to #151 and #236, but I didn't find the solution there.

[stof]

My analysis would be that direct calls on Encore are marked as unresolved, while chained calls are marked as resolved (or maybe as unknown due to the unresolved calls).

I just tried that. PHPStorm 2020.1 was working fine. After upgrading to PHPStorm 2020.2, I get this issue as well. So I would say that this is a PHPStorm issue rather than a webpack-encore one.

[stof]

I would say that the new version of PHPStorm does not recognize the type annotation of the export anymore: https://github.com/symfony/webpack-encore/blob/4038860f8c34da1db4e22b4461d88690ba6bc030/index.js#L1650-L1655

[yura3d]

@stof It seems PhpStorm 2020.2 can still recognize the type annotation for export:

But it can't use it later, in code expressions.
I've just found workaround to fix code highlighting and autocompletion (by calling getEncore()):

But it doesn't look perfect. It seems it's time to create an issue on PhpStorm/WebStorm tracker.

[stof]

This definitely look like a bug in PhpStorm/WebStorm if using such callback works

[yura3d]

The issue on PhpStorm Tracker: https://youtrack.jetbrains.com/issue/WI-54625

[stof]

thanks for doing that report.

[Alphamplyer]

just add doc over Encore require

[yura3d]

@Alphamplyer I tried this yet before writing my previous post and caught strange behavior. When I add @type everything is fine, but after restarting PhpStorm this doesn't work: only removing @type and bringing it back returns code analysis and autocompletion. But this solution is not for me as it requires additional action every time.

[Alphamplyer]

I'm agree, that's a temporary solution.

[zek0faws]

@yura3d Thanks for the report on PhpStorm Tracker.
It seems they are waiting for an answer from you, they want a repo with the issue. So I created a basic one.
Since it's your issue on their tracker they may need only you to answer.
You can use this repo: https://github.com/zek0faws/phpstorm-webpack-encore-issue

Hope that help.

[yura3d]

@zek0faws Thank you so much, I haven't enough time last months to make it by myself, so it's cool that you've done it. I've just left a comment about it in PhpStorm tracker.

[yura3d]

It seems everything is fine after updating to PhpStorm 2020.3, as the JetBrains staff said before on Tracker. So this issue may be closed.