Webpack-cli: Feature: Migrate should move CommonsChunkPlugin to SplitChunksPlugin

[ematipico]

Do you want to request a feature or report a bug?
Feature.

What is the current behavior?
At the moment migrate does nothing when it encounters CommonsChunkPlugin

What is the expected behavior?
It should migrate to SplitChunksPlugin

If this is a feature request, what is motivation or use case for changing the behavior?
CommonsChunkPlugin is now deprecated in webpack v4 and migrate, as its objective, should opt in in favor of SplitChunksPlugin

[dhruvdutt]

I can pick this up. :hand:

I think apart from changing name, there are some defaults as well that CommonsChunkPlugin was doing.

WDYT? @ematipico @montogeek

[ematipico]

Great! That was quick

[ematipico]

No, just changing the name is not enough. It's a complete different section of the configuration

https://webpack.js.org/plugins/split-chunks-plugin/#optimization-splitchunks

[montogeek]

@dhruvdutt First change is its name, second step is play a lot with all its options until it fits CCP behaviour, if you discover something new share it on webpack.js.org docs!

[PlayMa256]

@ematipico this was already merged #399 , we can close

[ematipico]

Are we sure? I am looking better at the PR, the changes were around different plugins.
Here the work is actually different because we have to migrate and existing CommonsChunkPlugin (I don't see any test around it).

@dhruvdutt was going to do that.

[evenstensberg]

Closed this by accident, a migration for commonsChunk would need to be added, as it has changed in newer versions of webpack. Nice catch, thanks!

[dhruvdutt]

I'm caught up with some university assignment until next week.
@ematipico @PlayMa256 @bitpshr Please feel free to catch this up if it's blocking next release. :)