Webpack-cli: Remove local fork of yeoman

Created on 27 May 2017  Â·  13Comments  Â·  Source: webpack/webpack-cli

Need an update from @pksjce on the bug she was complaining about recast. Moving to yeoman generators, so this needs to be resolved.

For the yeoman fork, this is removed and replaced in #148

Bug Hotfix Important High

Most helpful comment

The git dependency is causing our build to act up due to our proxy on some systems. :frowning_face: One more reason it would be great to get rid of the local fork dependency of yeoman as soon as possible! :wink:

All 13 comments

it appears this would address / resolve https://github.com/webpack/webpack-cli/issues/132

Probably, but not entierly sure

This is underway at #207 , yeoman might be trickier

The git dependency is causing our build to act up due to our proxy on some systems. :frowning_face: One more reason it would be great to get rid of the local fork dependency of yeoman as soon as possible! :wink:

Haha yeah working on it, but need to come up with a good workaround. There's a possibility we'll need to create a temporary .yo config file for each scaffold, which shouldn't be be necessary ..

We just ran into this issue too:

yarn install v0.27.5
[1/4] Resolving packages...
[2/4] Fetching packages...
error An unexpected error occurred: "https://codeload.github.com/ev1stensberg/generator/tar.gz/9e24fa31c85302ca1145ae34fc68b4f133251ca0: Request failed \"400 Bad Request\"".
info If you think this is a bug, please open a bug report with the information provided in "/Users/kimburgaard/dev/10e/release/build/enterprise-client/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

The workaround to get around this was to manually delete the yeoman-generator entry in our yarn.lock file and run yarn again.

Dependencies like these outside of the npm/yarn registries make me super uneasy for a couple of reasons. For one, npm learned the hard way to never allow publicly published packages to be deleted because it breaks dependents, and it requires more oversight to understand where all the 3rd party code comes from.

313 and #314 are both similar. Reverting to webpack-fork-yeoman-generator would fix the problem.

We can't at the moment because it exposes the cli to some vulnerabilities

I have special setup where I don't have git installed in the same environment, where I have npm. Not having git prevents me from installing webpack-cli at all.

@ematipico Which vulnerabilities?
I think we were having facing issues like #291 when using the npm published fork so we reverted to using the GitHub fork in #291 which introduces proxy bugs.

@ev1stensberg I'm getting the following. I believe this is due to a corporate firewall issue but could also be a proxy issue. Any ideas?

λ yarn add webpack-cli -D
yarn add v1.5.1
[1/4] Resolving packages...
warning webpack-cli > jscodeshift > [email protected]: � Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!
warning webpack-cli > jscodeshift > [email protected]: Package no longer supported. Contact [email protected] for more info.
error An unexpected error occurred: "https://raw.githubusercontent.com/ev1stensberg/generator/9e24fa31c85302ca1145ae34fc68b4f133251ca0/package.json: unable to get local issuer certificate".
info If you think this is a bug, please open a bug report with the information provided in ...

@mihir478 We've identified this error and the fix should out soon. You can track it at #323.
Thanks for reporting.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

anyulled picture anyulled  Â·  4Comments

AjayPoshak picture AjayPoshak  Â·  5Comments

r00nscapenab picture r00nscapenab  Â·  4Comments

billyjanitsch picture billyjanitsch  Â·  3Comments

RobotnickIsrael picture RobotnickIsrael  Â·  5Comments