Webodm: Remove glyphicon icons

Created on 7 Nov 2019  路  9Comments  路  Source: OpenDroneMap/WebODM

We should remove glyphicons in favor of font-awesome. Currently we use both.

good first issue help wanted improvements

Most helpful comment

Hi there, can I work on this issue?

All 9 comments

Hi there, can I work on this issue?

Of course @Mingos1 :+1:

Currently finishing up, what do I do with a glyphicon without a FA equivalent?

For example, "glyphicon glyphicon-saved" does not have one.

How about fa fa-check or fa-check-square ?

Thank you, going to add when I start working in a few.

Also, what can I do with the glyphicons integrated as class names?

Also, what can I do with the glyphicons integrated as class names?

Can you explain more details? I'm not sure I understood the question. :pray:

No worries. I came across the glyphicons in the button classNames (pictured below) and I was not sure if they could be replaced as the glyphicons within I tags (e.g.,).

Since the glyphicons are apart of bootstrap, I think it would involve removing the over styles ( e.g., btn, btn-primary) and possibly create a conflict.

Essentially, how should I approach this?

question_shot

I think it works fine to replace those classes (just keep the btn, btn-primary, etc.):

image

Have you run WebODM in development mode yet?

./webodm.sh start --dev

You can see your changes in real time.

Thanks for the tip; I reread the docs and downloaded Docker, which definitely made the process a lot quicker.

I finished up replacing all of the inline icons. I left all mentions of glyphicons in the stylesheets as is (in case you wanted to revert back to glyphs) and left 1 glyphicon component in (shown below) since I couldn't find a FA equivalent.

I'm going to include this note in the PR, too.

final_q

Was this page helpful?
0 / 5 - 0 ratings