Web3j: Improvement: Update rxjava to V2 on Android lib

Created on 7 Sep 2017 · 7Comments · Source: web3j/web3j

Hello,

would it be possible to update rxjava to Version 2 in the Android lib?

Thanks & Best regards,

Dirk

enhancement

Source

deisold

Most helpful comment

I started making the transition on a branch.

The integration tests fail when I run them, though.

yervantk on 23 Oct 2017

👍3

All 7 comments

It would be. However, unfortunately, the upgrade is non-trivial as web3j would need to start using Flowables instead of Observables. If you're keen to have it, you're welcome to submit a PR which I will gladly accept.

conor10 on 18 Oct 2017

Keen to take a more thorough look and talk about this.

From the brief look I did it seems like you could utilise some of the RxJava2 types if you were to upgrade version, however it would also likely break a lot of existing code for anyone using the reactive stuff in the current release without much ability to maintain compatibility or have them side by side based on how the Web3jRx interface is implemented in the rest of the core code

theres-still-more on 21 Oct 2017

I started making the transition on a branch.

The integration tests fail when I run them, though.

yervantk on 23 Oct 2017

👍3

@yervantk i've created a PR for #441 to fix the integration tests. You can check them out to help with this.

franz-see on 5 Aug 2018

Of note: RxJava 1 is marked EOL as of March 31 according to the official readme. As such any improvements to RxJava beyond 1.3.8 will only benefit users when the transition can be done.

It might be beneficial to broaden this issue to include a transition of the exposed APIs into separate plugin-like satellite projects. This would also allow users to minimize the size of the package they include.