Web3.py: Rename middleware_stack to middleware_onion

[dylanjw]

How can it be fixed?

see #1020

[carver]

I'm half-joking when suggesting onion. But I haven't come up with anything better. Maybe...

• middleware_layers
• middleware_pipeline

But I'm seriously okay with onion if we don't like anything else better.

[dylanjw]

I prefer middleware_onion to layers or pipeline. It gets the point across better I think. The onion analogy is pretty common.

[carver]

This doesn't seem to have actually been closed in #1020

[fubuloubu]

What about... just middleware? lol

[jMyles]

Is middleware better than middleware_onion?

The latter seems clearer to me. It says "thing that has layers that will be applied in a LIFO order" - like an arrow piercing an onion.

[dylanjw]

middleware_onion helps distinguish the class that ochestrates the middlewares from the middleware functions themselves.

@njgheorghita Can this issue be closed?

[njgheorghita]

@dylanjw 👍