Web3.js: invalid sign result

[toknT]

I am using web3 1.0 to sign some message ,and verifity it in contract.

let signature = await web3.eth.sign(msHash, accounts[0]);

If set web3's privoder to metamask it work well, my contract can return the correct address, but if set it to use infura or other eth node it return a invalid sign and my contract can't verifity it.

[Nipol]

I have experienced the same problem. This is solved by using the Elliptic module. https://github.com/indutny/elliptic
To be precise, v values are different.

[Aniket-Engg]

Problem may be signing prefix related as it differs across various methods. See: https://github.com/OpenZeppelin/openzeppelin-solidity/issues/644

[nivida]

@gurrpi Thanks for giving me additional details. I will check it out and fix it asap.

[Haidy777]

Not sure if I should add this directly to this issue, but I think there is some general error with 'elliptic'.
When using web3.eth.accounts.privateKeyToAccount I'm getting the following error:

TypeError: Cannot read property 'fromRed' of null
    at Point.getX (node_modules/elliptic/lib/elliptic/curve/short.js:416:17)
    at Point._encode (node_modules/elliptic/lib/elliptic/curve/base.js:294:16)
    at Point.encode (node_modules/elliptic/lib/elliptic/curve/base.js:303:28)
    at KeyPair.getPublic (node_modules/elliptic/lib/elliptic/ec/key.js:67:19)
    at Object.fromPrivate (node_modules/eth-lib/lib/account.js:25:34)
    at Proxy.privateKeyToAccount (node_modules/web3-eth-accounts/dist/web3-eth-accounts.cjs.js:101:48)

Using the latest version of web3 with node 10.

[3esmit]

Im also experiencing this problem. All v are returning 01 or 00, while they should be 27 or 28.
If I hack around the contract to add 27 when < 27, then it recovers wrong address.

[3esmit]

My problem was that ganache-cli is prepending the prefix "Ethereum Signed Message" in web3.eth.sign, and I also needed to change the v it returned from 00/01 to 27/28.

[nivida]

This got fixed during the refactoring. If you pass an address where a related local unlocked account exists will it sign the message locally and otherwise it will send it to the node/MetaMask. Please update to the latest version of Web3.js to get this fix.

[stevenlcf]

My problem was that ganache-cli is prepending the prefix "Ethereum Signed Message" in web3.eth.sign, and I also needed to change the v it returned from 00/01 to 27/28.

Same issue here. I also need to change the v from 00/01 (seems to be implemented in current web3js) to 27/28 to be compatible with geth and openzeppelin-solidity (^v2.2.0). Check this recent PR of openzeppelin-solidity: https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1622

[DalderupMaurice]

Not sure if I should add this directly to this issue, but I think there is some general error with 'elliptic'.
When using web3.eth.accounts.privateKeyToAccount I'm getting the following error:

TypeError: Cannot read property 'fromRed' of null
    at Point.getX (node_modules/elliptic/lib/elliptic/curve/short.js:416:17)
    at Point._encode (node_modules/elliptic/lib/elliptic/curve/base.js:294:16)
    at Point.encode (node_modules/elliptic/lib/elliptic/curve/base.js:303:28)
    at KeyPair.getPublic (node_modules/elliptic/lib/elliptic/ec/key.js:67:19)
    at Object.fromPrivate (node_modules/eth-lib/lib/account.js:25:34)
    at Proxy.privateKeyToAccount (node_modules/web3-eth-accounts/dist/web3-eth-accounts.cjs.js:101:48)

Using the latest version of web3 with node 10.

I had this issue on web3.js version v1.2.1. I had my privateKey between quotes in my .env file (nodejs - express project). Removing the quotes in the .env file made it work :)