Web: As a funder when I change my mind about who should work on my bounty and click stop work on a contributor. Their application information should not dissapear from the activity.

[PixelantDesign]

User Story

As a funder when I change my mind about who should work on my bounty and click stop work on a contributor. Their application information should not dissapear from the activity.

Why Is this Needed

Summary: Application information disappears from the activity feed. I'd like to still see their approach/plan submitted.

Description

Type: Enhancement

Current Behavior

See where Kichjang application info disappearrs

Expected Behavior

Application details should stay.

Definition of Done

Fix the above

Additional Information

This is the issue where it happened
https://gitcoin.co/issue/gitcoinco/web/6090/4070

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.2 ETH (44.58 USD @ $222.89/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $83,756.35 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Workers have applied to start work__.

These users each claimed they can complete the work by 3 weeks from now.
Please review their action plans below:

1) mul53 has applied to start work _(Funders only: approve worker | reject worker)_.

Hi would like to work on this.

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__Workers have applied to start work__.

These users each claimed they can complete the work by 1 month, 1 week ago.
Please review their action plans below:

1) chiptus has applied to start work _(Funders only: approve worker | reject worker)_.

Add a stop button in the issue that is visible for the funder.
Create an email to the contributor that tells him his works has been stopped.
Click stop will change the status of his work, and will send him an email
2) arun0930 has applied to start work _(Funders only: approve worker | reject worker)_.

Hihigooglkofjb. Giooudjdbbkdhudj

Learn more on the Gitcoin Issue Details page.

[sebastiantf]

@PixelantDesign,

The Work Plan submitted by a worker is stored in the interested array with the key issue_message as can be seen in the results of an API fetch of the bounty details:

https://gitcoin.co/api/v0.1/bounties/?github_url=https://github.com/gitcoinco/web/issues/6090&not_current=1

        "interested": [
            {
                "profile": {
                    "id": 75812,
                    "url": "/akshit-wwstay",
                    "handle": "akshit-wwstay",
                    "keywords": [
                        "JavaScript",
                        "TypeScript",
                        "Python",
                        "HTML"
                    ],
                    "position": 0,
                    "avatar_url": "https://c.gitcoin.co/avatars/1928941f6647b4cc785da87c4318470b/akshit-wwstay.png",
                    "github_url": "https://github.com/akshit-wwstay",
                    "total_earned": 0,
                    "organizations": {}
                },
                "created": "2020-02-28T15:49:28.075673Z",
                "pending": true,
                "signed_nda": null,
                "issue_message": "I am new to gitcoin. Excited to resolve an issue and learn how it works."
            },
            {
                "profile": {
                    "id": 68658,
                    "url": "/developerfred",
                    "handle": "developerfred",
                    "keywords": [
                        "JavaScript",
                        "Vue",
                        "PHP",
                        "Go"
                    ],
                    "position": 31,
                    "avatar_url": "https://c.gitcoin.co/avatars/abc63547d2ba979fa6e4de9a0d6341f6/developerfred.png",
                    "github_url": "https://github.com/developerfred",
                    "total_earned": 0.1,
                    "organizations": {
                        "esteemapp": 1
                    }
                },
                "created": "2020-02-28T15:40:58.196352Z",
                "pending": false,
                "signed_nda": null,
                "issue_message": "https://github.com/gitcoinco/web/issues/6090#issuecomment-592563130 \n\nI just asked to be added to this issue"
            },
            {
                "profile": {
                    "id": 75340,
                    "url": "/jay-dee7",
                    "handle": "jay-dee7",
                    "keywords": [
                        "Go",
                        "JavaScript"
                    ],
                    "position": 0,
                    "avatar_url": "https://c.gitcoin.co/avatars/c2ed492c2b0d3f02d5e656294fa6612b/jay-dee7.png",
                    "github_url": "https://github.com/jay-dee7",
                    "total_earned": 0,
                    "organizations": {}
                },
                "created": "2020-02-28T15:39:45.193662Z",
                "pending": true,
                "signed_nda": null,
                "issue_message": "this seems to be something pretty easy, lemme hop onto this one"
            }
        ],

When a worker is removed by the funder, the interest corresponding to the removed worker is deleted from the interested array by the function uninterested() in views.py

Hence, when process_activities() tries to get the issue_message (Work Plan) by the contributor and when render_activity() tries to render the activities on the html page, an object corresponding to kichjang is not found in the interested array and no corresponding issue_message is also not found.

This is why his Work Plan disappears.

[PixelantDesign]

Thanks @sebastiantf

On the interface it would be great if it was shown that the worker has been approved....and the workplan still displays in the activity where the contributor orginially applied.

Looking forward to seeing a PR!

[sebastiantf]

@PixelantDesign I think implementing a solution for this issue would require consulting the maintainers/core members of the gitcoin/web repo.

For a solution for this issue, we'll have to find a way of keeping a copy of the issue_message (Work Plan) submitted by the worker even when he/she is removed from the bounty.

One way of implementing the solution is:

Add another boolean field to the Interest model in model.py like removed or active which would be set according to whether the worker has been removed or not. Now, rather than deleting the whole Interest object of a worker when he/she has been removed, toggle this new boolean field. This lets us keep a complete history of all interested workers while preserving their issue_message (Work Plan) and also to identify removed workers.

Since this solution would require modifying the Interest model, I think it's best to consider suggestions from the Gitcoin core team.

What do you think @PixelantDesign?

[octavioamu]

@sebastiantf sorry I didn't know this was bountied, good you noticed the needed change of rules, there is an ongoing discussion about this here https://github.com/gitcoinco/web/issues/5102
not sure if @danlipert or @thelostone-mc already started something related to this, but if not maybe we can discuss and get to an agreement of the best way to solve it.

check my last comment on 5102 I pasted the original issue text, and the importa part is:

If the user "stop work" ( or is stopped) we shouldn't delete the interest.
work plans need to be related with the right activity or better, interest need to have the current action "work plan" and we can stop using the activity to manage the logic in the UI.

[sebastiantf]

Of course @octavioamu. We shall all discuss and reach an agreement about how we should proceed.

Happy to support.

[molecula451]

@octavioamu scrolling through this. I realize this is very close to which we'd require tackling the issue #5618 since you guys are touching about re-modeling the "interest". When a bounty it becomes 'done' and thus it will require feedback for all "Interested" users in this case all the users that applied to the bounty. [unrated_contributed_bounties] it's taking the object parameter interested___profile from Bounty class and in this case all the users that applied.

Desire model that could help us solve the problem #5618 it's found out in the BountyFulfillment class in fulfiller_github_username but stating this beforehand could overlap on the front-end.

Adding somehow new model for fulfiller in the Class Bounty

[gitcoinbot]

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[sebastiantf]

Yes @gitcoinbot. I shall need further directions from the Gitcoin Core team to move forward.

[gitcoinbot]

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[sebastiantf]

Yes @gitcoinbot. I shall need further directions from the Gitcoin Core team to move forward.

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__The funding of 0.2 ETH (42.68 USD @ $213.41/ETH) attached to this issue has been cancelled by the bounty submitter__

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $87,546.20 more funded OSS Work available on the Gitcoin Issue Explorer