Web: Website is slow and sluggish in Firefox

[abitrolly]

Describe the bug

In Firefox everything is extremely slow. Buttons are not clickable. Context menu does not appear. To click a button I have to close the support window and wait like 20 seconds. Network console shows hammering on Infura servers. Although it is not clear what exactly causes the slowness.

To Reproduce
Disable Metamask and load https://gitcoin.co/issue/alialiwa2005/Maple/1/3976 in Firefox.

Desktop (please complete the following information):

• OS: Fedora 31
• Browser: Firefox
• Browser Version: 72.0.1

Smartphone (please complete the following information):

• Device:
• OS:
• Browser:
• Version:

Additional context

[owocki]

hmmm interesting.. it seems to perform ok for me in FF ( i tried with and without metamask)

https://bits.owocki.com/eDu9d4W4

can you record a screenshot of the performance monitor so i can see what it looks like on ur machine? https://bits.owocki.com/eDu9d4W4

[owocki]

hmmm actually i take this back.. if u leave the site open for a while it does start to degrade.. https://bits.owocki.com/Jru7rJvL

looking at the perf monitor it points to reloadCbAddress() and listen_for_web3_changes() - which should only fire every few seconds but seems to just be infinitely refreshing with no delay

[abitrolly]

@owocki I sent a link to guys who professionally do web development. They've pointed to a few listeners who compete with each other, as well as to several code places that are example of a very bad practices, and after half an hour they said that their eyes bleed and they could not stand it anymore. :D Most of them are React adept though. Maybe it is worth to take a look at some frameworks for building reusable frontend apps.

[owocki]

the answer to this ticket is most certainly not "rewrite the entire app" (particularly not to something as over-engineered as React/Redux). if youre going to source devs for this ticket, maybe send it to someone who has constructive input to give.

[owocki]

https://www.joelonsoftware.com/2000/04/06/things-you-should-never-do-part-i/

Things You Should Never Do, Part I

The single worst strategic mistake that any software company can make:
They decided to rewrite the code from scratch.

[owocki]

the team put in a fix for this .. will go out next deploy

[abitrolly]

I am not familiar with React. Is it impossible to use it in parallel with other JS code?

[abitrolly]

the team put in a fix for this .. will go out next deploy

The issue is still there. How to track the next deploy? (label or something)

[abitrolly]

@owocki the issue is still there. How often is gitcoin.co deployed?

[owocki]

a few times per week

On Thu, Mar 5, 2020 at 5:01 AM Anatoli Babenia [e-mail]
wrote:

@owocki https://github.com/owocki the issue is still there. How often
is gitcoin.co deployed?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/5923?email_source=notifications&email_token=AAD5PCPFZZE6NWUYBW2FKSTRF6IC5A5CNFSM4KPAZ4K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN47HSA#issuecomment-595194824,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5PCO7FIRZYR5TT5MWRADRF6IC5ANCNFSM4KPAZ4KQ
.

--

@owocki http://www.twitter.com/owocki

---

gitcoin is live and has generated over $3.5mm for Open Source Software - see
our results https://gitcoin.co/results

[abitrolly]

@owocki then this bug is still not fixed.

[molecula451]

@owocki I am giving a look to gitcoin on firefox too see this

[owocki]

reproduction steps would be nice. failing that i still think we should add something in the settings that allows people to turn off the animations on their account

[abitrolly]

@owocki just open https://gitcoin.co/issue/alialiwa2005/Maple/1/3976 in anonymous tab in Forefox and wait 5 seconds for it to become sluggish.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.15 ETH (30.8 USD @ $205.3/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $73,672.59 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[sebastiantf]

@owocki Please take a look at the PR #6187

[owocki]

does it fix the issue? how did you test it?

note: the engineering team will be reviewing the PR, but from a quick
glance you removed the 'testing' section from the template.

On Mon, Mar 9, 2020 at 12:59 PM Sebastian T F [e-mail]
wrote:

@owocki https://github.com/owocki Please take a look at the PR #6187
https://github.com/gitcoinco/web/pull/6187

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/5923?email_source=notifications&email_token=AAD5PCIH2BVD6JO6LITTY5LRGU4A5A5CNFSM4KPAZ4K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOIUJ4Y#issuecomment-596722931,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5PCJR3D3K6YLVO6FG3EDRGU4A5ANCNFSM4KPAZ4KQ
.

--

@owocki http://www.twitter.com/owocki

---

gitcoin is live and has generated over $3.5mm for Open Source Software - see
our results https://gitcoin.co/results

[sebastiantf]

Sorry for removing the Testing section.

This commit would increase the delay of checking the web3 change from 1sec to 5secs. It would increase the performance of the website when MetaMask is disabled.

[owocki]

but did you reproduce the issue and test it locally?

On Mon, Mar 9, 2020 at 1:12 PM Sebastian T F [e-mail]
wrote:

Sorry for removing the Testing section.

This commit would increase the delay of checking the web3 change from 1sec
to 5secs. It would increase the performance of the website when MetaMask is
disabled.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/5923?email_source=notifications&email_token=AAD5PCLZBS4GFG7FDICNVFLRGU5SVA5CNFSM4KPAZ4K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOIV2NA#issuecomment-596729140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5PCMK3KGC3VXQXFI3SLTRGU5SVANCNFSM4KPAZ4KQ
.

--

@owocki http://www.twitter.com/owocki

---

gitcoin is live and has generated over $3.5mm for Open Source Software - see
our results https://gitcoin.co/results

[sebastiantf]

Yes @owocki I tested the issue before and after changing the delay for listen_for_web3_changes.

There is great improvement in the performance. You could identify the drop in performance if you try scrolling the page up and down continuously. The scrolling of the site would hang for a second whenever the listen_for_web3_changes fires. When the delay is 1s, the site hangs every second, making it unusable. When it is increased to 5s, the site would hang only in 5-second intervals which is far better that hanging every second.

If it's fine, we could further increase the delay which would further improve the performance.

[owocki]

thnaks so much! sounds promising

[owocki]

thanks so much!

On Tue, Mar 10, 2020 at 8:08 AM Sebastian T F [e-mail]
wrote:

Yes @owocki https://github.com/owocki I tested the issue before and
after changing the delay for listen_for_web3_changes.

There is great improvement in the performance. You could identify the drop
in performance if you try scrolling the page up and down continuously. The
scrolling of the site would hang for a second whenever the
listen_for_web3_changes fires. When the delay is 1s, the site hangs every
second, making it unusable. When it is increased to 5s, the site would
hang only in 5-second intervals which is far better that hanging every
second.

If it's fine, we could further increase the delay which would further
improve the performance.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/5923?email_source=notifications&email_token=AAD5PCNKKDDS3Y77UJIWVXTRGZCVXA5CNFSM4KPAZ4K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOLRXRI#issuecomment-597105605,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5PCMKGAU4WN43CGFABDTRGZCVXANCNFSM4KPAZ4KQ
.

--

@owocki http://www.twitter.com/owocki

---

gitcoin is live and has generated over $3.5mm for Open Source Software - see
our results https://gitcoin.co/results

[abitrolly]

@sebastiantf extending delay from 1 second to 5 just hides the problem without the fix. The check for a missing extension is not computation expensive and should not lead to 1 second block every 5 seconds.

[sebastiantf]

@abitrolly Should I implement a solution that checks whether the extension is installed/disabled only one time in the beginning when the page loads?

[abitrolly]

@sebastiantf the solution is to identify interface blocker. It maybe a race condition between different hooks or a loop with stack overflow. I don't remember pages that block interface and links on a page when waiting for server reply.

[gitcoinbot]

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@sebastiantf due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__Work has been started__.

These users each claimed they can complete the work by 2 weeks, 1 day ago.
Please review their action plans below:

1) cybot1711 has been approved to start work.

A proper assessment of the underlying problem. Upon exposing the issue the work shall be tasked out and estimated. After estimation and feasibility development will commence.

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

@cybot1711 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@cybot1711 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[abitrolly]

The behaviour is not repeatable anymore, and refactoring is another issue. Therefore I am closing it. Thanks everyone for participating in resolving it.

[gitcoinbot]

@cybot1711 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[abitrolly]

Unsubscribed because of the bot. Please tag me explicitly if needed.

[gitcoinbot]

@cybot1711 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[owocki]

im canceling the bounty since it doesnt seem to be going anywhere.

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__The funding of 0.15 ETH (28.02 USD @ $186.82/ETH) attached to this issue has been cancelled by the bounty submitter__

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $126,075.52 more funded OSS Work available on the Gitcoin Issue Explorer