Web: Add warning for Brave users

[paulrberg]

In v1, Brave introduced their native crypto wallet, which is rather intrusive and overrides Metamask.

Some users told me they would've loved to contribute to our Sablier grant, but they couldn't because nothing happened after tapping the submit button. I jumped on TeamViewer to help them and it turned out that the issue was Brave - after disabling it, it went fine.

It'd be nice to display a warning for Brave users. Related: https://github.com/brave/brave-browser/issues/6053

[LefterisJP]

Yeah I saw the same in the previous gitcoin round. That's why I disabled Brave's own crypto wallet.

[owocki]

adding a bounty for thsi. scope is to fix grant contributions (and cancellations) in brave's native wallet

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.5 ETH (83.55 USD @ $167.1/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $75,101.84 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Workers have applied to start work__.

These users each claimed they can complete the work by 1 month from now.
Please review their action plans below:

1) iamonuwa has applied to start work _(Funders only: approve worker | reject worker)_.

Check if browser is brave browser . Then show message

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 1 week, 2 days ago.
Please review their action plans below:

1) iamonuwa has applied to start work _(Funders only: approve worker | reject worker)_.

Check if browser is brave browser . Then show message
2) iamonuwa has applied to start work _(Funders only: approve worker | reject worker)_.

Check if browser is brave browser . Then show message
3) sebastiantf has been approved to start work.

Write code to detect what browser the user is using. Display a warning message to users if they're using Brave

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[sebastiantf]

Yes. I am working on this issue @gitcoinbot.

[sebastiantf]

How would you like the warning to be displayed @PaulRBerg @owocki?

Should it look like an .alert like this:

Or should it look like a .modal like this:

[gitcoinbot]

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[sebastiantf]

@gitcoinbot I am working on this issue. I would like to receive a reply for the previous comment.

I shall move forward by trying to implement a .alert

[gitcoinbot]

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[sebastiantf]

Yes @gitcoinbot

[sebastiantf]

@owocki @PaulRBerg Brave browser doesn't seem to provide a Brave-specific User Agent which makes detecting Brave browser difficult. See #1052

Since Brave Wallet is a fork of MetaMask, the web3.currentProvider.isMetamask returns true.

So it seems displaying the warning only for Brave users by detecting Brave Browser or Brave Wallet to be hard.

Is it okay to just display the following warning to all users visiting https://gitcoin.co/grants/?

_Note: Brave users seem to have issues while contributing to Grants while using both Brave Wallet and MetaMask. We recommend disabling one. For more info, see this issue_

[gitcoinbot]

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[sebastiantf]

Yes @gitcoinbot

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 0.5 ETH (134.64 USD @ $269.27/ETH) has been submitted by__:

1. @sebastiantf

@owocki please take a look at the submitted work:

• PR by @sebastiantf

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $90,391.75 more funded OSS Work available on the Gitcoin Issue Explorer

[sebastiantf]

@owocki My PR has been merged and this issue closed. I have submitted the work on Gitcoin. Please review my work as the bounty expires in 2 days.

[owocki]

just paid out

is there no way to detect the user is in brave and only display the message them? it seems really really clunky to get this warning on chrome

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 0.5 ETH (114.83 USD @ $229.66/ETH) attached to this issue has been approved & issued to @sebastiantf.__

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $82,458.83 more funded OSS Work available on the Gitcoin Issue Explorer

[sebastiantf]

Thanks for the payment @owocki.

It seems it isn't possible to detect Brave users using the UA as they've removed Brave-specific strings from it to reduce fingerprinting as specified in this Changelog

Also see #1052

If any alternative method is found, we shall use that to detect Brave and show the warning specifically to Brave users.

[dlecan]

https://gist.github.com/drbh/250a77a438624bc2619f0518dd5b38fe + discussions