Web: Uploading folders does not work in files-drop

Created on 12 Nov 2019  ยท  9Comments  ยท  Source: owncloud/web

Steps to reproduce

  1. Create a files-drop link.
  2. Open the files-drop link.

Expected behaviour

Some way to upload folder

Actual behaviour

No way to upload a folder. Dragging a folder uploads the contents of the folder (recurse through it and flattens them).
Also, using setValue and trying to upload folder through Nightwatch creates an empty file.

p3-medium Bug files

Most helpful comment

@pascalwengerter, uploading folders seems to work but all the files in the folder will be flattened.
for example, if we upload a folder with the following structure

โ”œโ”€โ”€ upload
โ”‚ย ย  โ”œโ”€โ”€ file1.pdf
โ”‚ย ย  โ”œโ”€โ”€ file.ttf
โ”‚ย ย  โ””โ”€โ”€ sub
โ”‚ย ย      โ””โ”€โ”€ file2.pdf

it will upload all 3 files file1.pdf, file.ttf, and file2.pdf will be uploaded in the same folder. Is that correct behavior?

Uploading a similar folder in the main files section keeps the folder structure of the originally uploaded folder.

All 9 comments

@skshetry mind trying this with OC 10 ?

as far as I remember we don't support subdirectories in files drop mode so this might be expected behavior

@PVince81, Folder uploads in OC 10 are not supported at all. Close this or is this a requirement (it is listed on #2222)?

Also, phoenix should not upload folder as an empty file nor should it flatten them and upload inside a same folder.

not a requirement imo, it would mess up the concept and make it more complex as we'd need to avoid file name collisions even across folders.

@pmaier1 thoughts ?

@pmaier1 please reopen if you think we want to change how it works in Phoenix

@PVince81, then, I would not expect the contents of sub-folders getting uploaded in the root of the publicly-shared folder (at least they should be in their respective sub-folders).

Re-opening, feel free to close if you don't think, that is an issue.

@skshetry you're right. We need to block this with a warning.

@skshetry could you retry this with all the changes that have occured in the last ~1,5 years? Should work fine now ๐Ÿ˜‰

@pascalwengerter, uploading folders seems to work but all the files in the folder will be flattened.
for example, if we upload a folder with the following structure

โ”œโ”€โ”€ upload
โ”‚ย ย  โ”œโ”€โ”€ file1.pdf
โ”‚ย ย  โ”œโ”€โ”€ file.ttf
โ”‚ย ย  โ””โ”€โ”€ sub
โ”‚ย ย      โ””โ”€โ”€ file2.pdf

it will upload all 3 files file1.pdf, file.ttf, and file2.pdf will be uploaded in the same folder. Is that correct behavior?

Uploading a similar folder in the main files section keeps the folder structure of the originally uploaded folder.

@pascalwengerter
Is the current behavior the expected one?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

DeepDiver1975 picture DeepDiver1975  ยท  3Comments

jnweiger picture jnweiger  ยท  7Comments

individual-it picture individual-it  ยท  5Comments

kulmann picture kulmann  ยท  4Comments

PVince81 picture PVince81  ยท  7Comments