Web: Gitcoin Quests - Improvements, enhancements and corrections

[Solexplorer]

Describe the bug

1) When I create a quest, don't allow negative numbers to be inputed, doing this prevents the user from receiving negative points( this has happened to me 😂 ) or not having enough time:

2) When creating a new question, the question above gets copied with its answers to the new question:

3)The same happens when I copy answers, the previous answer gets copied below, I would like to have the field empty when adding new answers:

4-Limit a maximum amount of answers that a quest creator can put, I was able to put more than 15 answers in a question, IMO it's not very good to have that much of answers available

To Reproduce

Recreate what I have explained above when creating a new quest

Expected behavior

Screenshots

Desktop (please complete the following information):

• OS:
• Browser:
• Browser Version:

Smartphone (please complete the following information):

• Device:
• OS:
• Browser:
• Version:

Additional context

[Solexplorer]

Please, if you don't understand something that I wrote, I will be available to explain 😄

[kuhnchris]

Yo @Solexplorer i took the freedom and renamed the title a bit. Would you mind cross-referencing that in the big gitcoin quest ticket? I think that's what Kevin is mostly looking at. thanks!

[Solexplorer]

@kuhnchris Oh, just done it, thanks for your input!

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.4 ETH (72.16 USD @ $180.4/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $101,792.95 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 1 week, 4 days from now.
Please review their action plans below:

1) straumer has been approved to start work.

I can give this a try. Plan:

1. Reproduce these bugs.
2. Learn about the existing setup for form validation and handling.
3. Fix bugs as cleanly as possible.
4. Maybe write tests? Depends on the setup of this project.
   2) naszam has been approved to start work.

Something nice to see during the creation of a quest is not having the question being repeated when you add a new question. Also to have a error that pops up when you submit the quest to inform you to specify YES if is not being selected during the creation process.
3) sirlupinwatson1 has applied to start work _(Funders only: approve worker | reject worker)_.

i will work on this one and i will start to work on it as soon as possible.
4) ariesjia has applied to start work _(Funders only: approve worker | reject worker)_.

The bug description is clear, it's easy to fix it.

Learn more on the Gitcoin Issue Details page.

[Sirlupinwatson1]

Clone, fork, run it in powershell, test, make all test, debug, config.

[zoek1]

hey @owocki i can't click the submit work button but here is a PR ready to review that cover all points: https://github.com/gitcoinco/web/pull/5393

[owocki]

why cant you click the submit work button? will check it out..

[gitcoinbot]

@straumer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[straumer]

Not directly yet, setting up my dev environment etc. as I'm new to the project. But seems like there's a solution already. Am I blocking @zoek1 maybe? That's how it works right? That I would have to stop working on it for others to submit work.

[straumer]

Also, seems like there are no fixtures for the quests, giving errors in the dev environment. Are people creating them manually now to be able to work on things?

[kuhnchris]

probabbly - I haven't checked out the environment lately, but you can go to /_administration/ and find quests there and add one there. Could you also throw up the error you are receiving? thanks.

[straumer]

@kuhnchris, I tried the PR branch that @zoek1 mentioned above and it fixes those errors. Just Zero division and no attribute errors due to no Quests/QuestAttempts etc. existing in the database.

That PR branch fixes nr. 1 on this issue (negative inputs), but the rest is unfinished. But I'm slightly confused right now about how traditional bounties work exactly. I can use zoek's branch in the rest of the solution in any case.

[straumer]

No I was wrong. zoek1's branch fulfills nr. 1, 2 and 3 of this issue. Although, the questions/answer fields that are added have a red error outline. Would be nice if there'd be no error outline at first.

Gonna see about nr. 4 and this initial red outline.

[zoek1]

why cant you click the submit work button? will check it out.

I'm not sure, i clicked to 'stop work' button to see if applying again solves the problem but the button to start work disappears.

@owocki

[straumer]

My submit work button works. I'm ready to submit, but I just need ETH first. xD

[owocki]

submit a faucet req pls! gitcoin.co/faucet

[straumer]

I already did. :)

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 0.4 ETH (73.74 USD @ $184.34/ETH) has been submitted by__:

1. @straumer

@owocki please take a look at the submitted work:

• PR by @straumer

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $124,665.29 more funded OSS Work available on the Gitcoin Issue Explorer

[zoek1]

Hey @owocki, friendly question: The PR #5433 was merged. Actually, such MR was based on my PR #5393, at that moment my PR covered 3/4 points, after that @straumer accurately cover the point and enhance the work. So it is possible this bounty us cooperative and rewards each user according to his work. I'm ok if that is not possible, the important thing already happened, contributing to gitcoin!

[straumer]

I'm fine with that too if possible.

[straumer]

Oh yea. I should mention that point 1 and 2 were covered by @zoek1. I noticed in the end that 3 and 4 were not, so I covered those.

[owocki]

happy to payout both. just ping me when urs is merged @zoek1

[gitcoinbot]

⚡️ A *Limited Edition Ninja Bot* Kudos has been sent to @straumer for this issue from @owocki. ⚡️ Nice work @straumer! Your Kudos has automatically been sent in the ETH address we have on file.

[straumer]

@owocki His are merged. I built upon his commits in my PR. :) And thanks.

[gitcoinbot]

⚡️ A tip worth 0.40000 ETH (73.64 USD @ $184.09/ETH) has been granted to @zoek1 for this issue from @owocki. ⚡️

Nice work @zoek1! Your tip has automatically been deposited in the ETH address we have on file.

• $128228.18 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 0.4 ETH (73.64 USD @ $184.09/ETH) attached to this issue has been approved & issued to @straumer.__

Additional Tips for this Bounty:

• owocki tipped 0.4000 ETH worth 73.64 USD to zoek1.

---

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $128,154.54 more funded OSS Work available on the Gitcoin Issue Explorer