Web: [Profile / Dashboard / Feedback] Multiple broken feedback items

[kuhnchris]

Describe the bug
Evaluated/rated my bounty interactions, got the same bounty 4 times, can only interact with the first

To Reproduce
unknown

Expected behavior
Correct amount of bounties to rate

Screenshots

[PixelantDesign]

Thanks for the report!

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.2 ETH (53.76 USD @ $268.82/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $71,462.98 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[kuhnchris]

Just a quick heads up: may this be connected to the Rinkeby issue? (just a heads up @uivlis, so we are not doing double work)

https://github.com/gitcoinco/web/pull/4344

[uivlis]

If a bounty was first posted on Rinkeby and then moved to Mainnet, shouldn't it appear only twice, or, at most, a few times? I have hundreds of duplicates on my profile, I can't see how this bug would be connected with that issue, but am investigating.

[kuhnchris]

Hello,

well, if they use the same ID, or IDs only valid on rinkeby, it may cause issues like that, but please, do investigate, it was only a lead, just to make sure you're not double-investigating. ;-)

[owocki]

how was a bounty moved from rinkeby to mainnet?

[kuhnchris]

Not sure, I just assumed he meant that if the ids from rinkeby bounty match (some other) mainnet bounty...

[uivlis]

No, yeah, well I thought... anyway, nevermind.
I barely managed to build the docker image and play with the admin dashboard. I'm not sure where lays the bug (yet), however, I can't reproduce the issue locally (yet).

[uivlis]

Right, I've been able to reproduce the issue locally. Does that rule out the possibility of mismatching mainnet and rinkeby ID's, since there are no mainnet bounties locally?

[uivlis]

Apparently, I was wrong. The duplicates I saw were not so duplicates (they were in the 'Funded' section, just multiple fulfillments). I cannot, however, reproduce anything in the 'Contributed' pan.

I allocated a bit too much time on this bounty, so if I cannot move forward in the following days, I will have to backtrack, unfortunately.

[PierrickGT]

@kuhnchris I've tried to reproduce this bug in local but without any success. For each bounties completed I did only have one unrated bounty card.

I think the problem lies in the data, cause in production we have the same kind of problem in the All activity tab.

Here is the piece of code in app/dashboard/views.py, that retrieves the unrated bounties:

    context['unrated_funded_bounties'] = Bounty.objects.current().prefetch_related('fulfillments', 'interested', 'interested__profile', 'feedbacks') \
        .filter(
            bounty_owner_github_username__iexact=profile.handle,
            network=network,
        ).exclude(
            feedbacks__feedbackType='approver',
            feedbacks__sender_profile=profile,
        )

context['unrated_contributed_bounties'] = Bounty.objects.current().prefetch_related('feedbacks').filter(interested__profile=profile, network=network,) \
            .filter(interested__status='okay') \
            .filter(interested__pending=False).filter(idx_status='done') \
            .exclude(
                feedbacks__feedbackType='worker',
                feedbacks__sender_profile=profile
            )

I don't really know how I could fix this problem since I don't have access to the production database but I hope it can help the team figure out where the problem is coming from. :)

[kuhnchris]

Thanks for trying @PierrickGT - guess we will have to try to find some irregularities in the database then.

[owocki]

i think this should do it https://github.com/gitcoinco/web/pull/4842

[PierrickGT]

i think this should do it #4842

Nice! I should have been more persistent to complete this bounty haha.

[kuhnchris]

Well, we will see if this "fixes" it. If those entries exist with multiple PKs then Kevin's fix will be moot. but I vote for attempting to try it and see if it fixes it. :-)

[owocki]

its not that the entries exist with multiple PKs, its that the JOIN creates multiple rows for the same PK

[kuhnchris]

then we can try it

[PierrickGT]

@kuhnchris @owocki since I've helped debug this issue, do I qualify for the bounty reward?

[owocki]

we typically give out rewards to those who have completed the bounty.. but i'd be happy to leave a tip for you here.

[PierrickGT]

we typically give out rewards to those who have completed the bounty.. but i'd be happy to leave a tip for you here.

Thank you @owocki!

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__The funding of 0.2 ETH (44.63 USD @ $223.14/ETH) attached to this issue has been cancelled by the bounty submitter__

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $134,498.86 more funded OSS Work available on the Gitcoin Issue Explorer

[PierrickGT]

Hi @owocki,
Are you still planning on tipping me for this issue?
I would understand if you don’t, for the reason you’ve mentioned, just want to know where you stand. 🙂

[gitcoinbot]

⚡️ A tip worth 0.10000 ETH (21.38 USD @ $213.83/ETH) has been granted to @pierrickgt for this issue from @owocki. ⚡️

Nice work @pierrickgt! Your tip has automatically been deposited in the ETH address we have on file.

• $142877.72 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack