Web: rounding issue on the new bounty page

Created on 11 Apr 2019  路  15Comments  路  Source: gitcoinco/web

Most helpful comment

@pandyamarut / @owocki I'd recommend round them to 4 decimal places using .toFixed(4) as that's what we are rounding off the other amounts !
Ensure this change gets added to both increase_bounty.js & new_bounty.js

Do attach screenshot of the change and we'll get it in ^_^

All 15 comments

fix this rounding issue. maybe round to 3 decimal places

@owocki Please assign.

@pandyamarut i cant assign u since ur not on the repo. but feel free to start work! anyone else seeing this, pls check with @pandyamarut before u start

@pandyamarut / @owocki I'd recommend round them to 4 decimal places using .toFixed(4) as that's what we are rounding off the other amounts !
Ensure this change gets added to both increase_bounty.js & new_bounty.js

Do attach screenshot of the change and we'll get it in ^_^

@thelostone-mc got it. :+1:

@thelostone-mc ERROR: for redis Cannot start service redis: driver failed programming external connectivity on endpoint web_redis_1 (8ee787512e5a28ff3cf4b6d8fd9d0e420963e7927d63b1edcb04a2cdba6bf437): Error starting userland proxy: listen tcp 0.0.0.0:6379: bind: address already in use
ERROR: Encountered errors while bringing up the project.
^^^ I repeatedly tried killing the process but still it throws the same error.
Can you help me encounter this error?"" @owocki @thelostone-mc

Hmm I've not this seen this !
I'm assuming you've double checked nothing is running on that right ?

Could you purge the containers & run docker-compose down --build
cc @SaptakS have you seen this ?

@thelostone-mc Yes I checked multiple times.

@SaptakS @thelostone-mc Can you help me encounter this error?

Hmm I'm not able to reproduce this 馃槗
@danlipert / @owocki

@pandyamarut were you able to figure this out? Can you show me the output of lsof -i -P -n?

@danlipert Let me try. I'll get back.

Screenshot from 2019-05-08 19-45-08
this is the output @danlipert

@pandyamarut Uppercase P in the command - but basically I'm trying to figure out whats bound on your system to 6379

Btw this issue of rounding the numbers has been resolved ! It was popping up and folks were reporting it so had to throw in the fix a while back 馃槗

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ghost picture ghost  路  3Comments

kziemianek picture kziemianek  路  3Comments

owocki picture owocki  路  4Comments

kuhnchris picture kuhnchris  路  4Comments

kziemianek picture kziemianek  路  3Comments