Web: [View signed NDA] opens file save dialog with wrong file name generated

Created on 9 Apr 2019  路  9Comments  路  Source: gitcoinco/web

Wrong file name
To Reproduce
Expected behavior
Correctly generated file name

Screenshots
image

Desktop (please complete the following information):

  • OS: Gentoo Linux, 4.19.27-gentoo-r1 #4 SMP Fri Apr 5 19:36:52 EEST 2019 x86_64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz GenuineIntel GNU/Linux
  • Browser Google Chrome Stable
  • Browser Version 73.0.3683.86
bug

Most helpful comment

Fix is over at https://github.com/gitcoinco/web/pull/4151 which is merged in !

Sorry about the confusion.
I assumed this was a private repo bounty

All 9 comments

Thanks @gutsal-arsen can you post the bounty link?

@octavioamu sure

I believe this will be fixed with #4151 deployment, should happen in a couple of days

@octavioamu how to proceed with current bounty? seems it will stuck for couple of days for everyone.

With https://gitcoin.co/issue/Giveth/giveth-dapp/740/2765 ? this bug is not interfering with this, looks like the funder just didn't approve nobody yet.

@octavioamu well, shouldn't we sign the NDA? If so, should we download it?

Ah @gutsal-arsen you are right ! The NDA file seems to be corrupted.
The team is looking into it. Will ping you with an update! Thanks for raising this :)

Parallely we'll ping the bounty owner and give them a heads up too

@octavioamu well, shouldn't we sign the NDA? If so, should we download it?

No, there is not nda, that is just for private repos

Fix is over at https://github.com/gitcoinco/web/pull/4151 which is merged in !

Sorry about the confusion.
I assumed this was a private repo bounty

Was this page helpful?
0 / 5 - 0 ratings

Related issues

uluhonolulu picture uluhonolulu  路  3Comments

kziemianek picture kziemianek  路  3Comments

NukeManDan picture NukeManDan  路  3Comments

thelostone-mc picture thelostone-mc  路  4Comments

frankchen07 picture frankchen07  路  4Comments