Web: Failed cancelSubscription still listed as "canceled subscription"

[pascalvanhecke]

Describe the bug

A grant page (example https://gitcoin.co/grants/48/uniswap ) has a list of canceled subscriptions. This list is not accurate in two ways:

• failed cancellations still listed as actual cancellations
• cancel txs that were overridden with a higher gas cost still listed as actual cancellations

• tx failed: https://etherscan.io/tx/0xb582e4a7d64a323fec84c59cd28ac6f9666a0e989e90f54a2565dd809bd6266d
• tx overridden: bottom link points to https://etherscan.io/tx/0x0

Expected behavior

• failed and overridden cancellations should not be listed under actual cancellations

Screenshots

• see attached

[PixelantDesign]

Thanks for the report @pascalvanhecke!
cc @frankchen07

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.33 ETH (45.5 USD @ $137.89/ETH) attached to it as part of the gitcoinco fund.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $42,474.82 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[frankchen07]

@damianlarrosa let me know if there's any additional information you need to get started on this issue!

[frankchen07]

hi @damianlarrosa, any progress here? if not, I will remove you from this bounty and release back to the public. If you decide you want to try again, feel free to start work again.

[frankchen07]

@damianlarrosa I'm removing you from this bounty because you've been non-responsive. If the bounty is still open later and you decide to work on the bounty, please try and post more frequent updates!

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 9 months, 2 weeks from now.
Please review their action plans below:

1) speedyfixer has started work.

I'm working on a related bug (#3763), so I'm going to fix both.

My plan:

• [ ] is this issue related to #3763 ?
• [ ] Describe a group of steps for reproduce the bug
• [ ] Fix the bug
• [ ] Test the solution

Learn more on the Gitcoin Issue Details page.

[speedyFixer]

Updated Plan status:

• [x] is this issue related to #3763 ?
• [x] Describe a group of steps for reproduce the bug _Working in this item_
• [x] Fix the bug
• [x] Test the solution

[speedyFixer]

Issues aren't related, seems just a query bug.

With Q(error=True) in the query:

https://github.com/gitcoinco/web/blob/9ea8fbeaf0f545d210f3362d35239cbc2244552b/app/grants/views.py#L134

The result is:

Without Q(error=True) in the query:

[speedyFixer]

On the other hand, I saw that We are using error for identify a one time contribution:

https://github.com/gitcoinco/web/blob/9ea8fbeaf0f545d210f3362d35239cbc2244552b/app/grants/views.py#L436

@owocki How do you filter One Time Contribution vs a Failed subscription?

Failed Subscription:
Active = False
Error = True

One Time contribution:
Active = False
Error = True

Active Subscription:
Active = True
Error = False

Inactive Subscription:
Active = False
Error = False

[owocki]

failed subscriptions will have .error = True

one time contribution will have subscription.num_tx_approved = 1

failed contributions will have transaction.success=success

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 0.33 ETH (56.57 USD @ $171.43/ETH) has been submitted by__:

1. @speedyfixer

@frankchen07 please take a look at the submitted work:

• PR by @speedyFixer

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $97,456.04 more funded OSS Work available on the Gitcoin Issue Explorer

[frankchen07]

@speedyFixer - been traveling, will take a look and do payout soon! :)

[speedyFixer]

No problem :)

[speedyFixer]

@frankchen07 any update? :)

[frankchen07]

@speedyFixer - just got to it. Just paid out. Let me know if you've received it!

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 0.33 ETH (65.6 USD @ $198.79/ETH) attached to this issue has been approved & issued to @speedyFixer.__

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $98,617.46 more funded OSS Work available on the Gitcoin Issue Explorer

[speedyFixer]

@frankchen07 thanks!