Web: migrate gitcoin from web3js 0.2 to 1.0

[owocki]

the objective of this ticket its to migrate gitcoin from web3js 0.2 to 1.0

i've started a base branch at https://github.com/gitcoinco/web/commit/13bc312dd50b587197932bb7bc8c053b974d68f1 which you can use.

success criteria:

• repo is upgraded to web3js 1.0
• all references to web3.eth.coinbase updated
• BOUNTIES: a funder can post a new bounty
• BOUNTIES: user can fulfill a bounty
• BOUNTIES: funder can increase payout
• BOUNTIES: funder can accept a fulfillment (basic payout)
• BOUNTIES: advanced payout works
• TIPS: a user can post a new tip
• TIPS: a user can receive a tip
• ENS: a user can register an ENS subdomain at /ens
• FAUCET: User can submit a new faucet page
• FAUCET: admin can fund a faucet distribution.
• REQUESTS: User can submit a new requests request

replaces https://github.com/gitcoinco/web/issues/2369

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.5 ETH (112.72 USD @ $225.44/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $47,539.92 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[owocki]

@usmanmuhd are you working on this? any updates?

[usmanmuhd]

@owocki I will open WIP PR in just a while.

[gitcoinbot]

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@usmanmuhd due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] warning (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[usmanmuhd]

Working on this, will push in changes tomorrow.

[owocki]

@usmanmuhd any update

[usmanmuhd]

@owocki I had a few doubts, I guess they are addressed now. Will make the required changes and push in.

[rmshea]

@usmanmuhd Ryan from Gitcoin checking in here. Do you have any questions? I didn't see a PR from you 😄 Let me know if you need anything with this issue 🔨

[usmanmuhd]

@ryan-shea I have a WIP PR open. Had to turn in a few assignments. Hopefully this should be resolved by this weekend.

[usmanmuhd]

Just informing that I will continue working on this once #2548 is merged. I guess we need to change most of the existing js to work in an async fashion.

[gitcoinbot]

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@usmanmuhd due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] warning (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[owocki]

I guess we need to change most of the existing js to work in an async fashion.

why?

[usmanmuhd]

Most of the functions in 1.0 return promises. This is leading to a lot of errors here and there. I will do this once I finish eip1102.

[gitcoinbot]

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[owocki]

Most of the functions in 1.0 return promises. This is leading to a lot of errors here and there. I will do this once I finish eip1102.

I'm not sure how we're going to do this given we don't have a JS build pipeline for Gitcoin.

[rmshea]

Hey @owocki, snoozed the bot on this one. Are you going to open up the bounty to other hunters as well?

[usmanmuhd]

I'm not sure how we're going to do this given we don't have a JS build pipeline for Gitcoin.

Do you mean for testing the patches?

[owocki]

Hey @owocki, snoozed the bot on this one. Are you going to open up the bounty to other hunters as well?

I think that @usmanmuhd is still working on this right?

Do you mean for testing the patches?

Oh I had thought that not all browseres support async/await -- so we needed to have a npm build pipeline.. Perhaps I was wrong EDIT: isnt this called ES6?

[usmanmuhd]

Yeah, it's called ES6. I guess almost everyone supports it except IE :stuck_out_tongue:.

[owocki]

one thing we talked about doing on the internal team call today @SaptakS @mbeacom @thelostone-mc was just not supporting very old IE browsers..

[gitcoinbot]

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[pinkiebell]

What's the status on this one?
I and others hit errors because properties web3.eth.coinbase = null but the async web3.eth.getCoinbase works.

@owocki
Can we up this to high prio?

[usmanmuhd]

I'll do this now. Need a rebase so that I can get kudos and the other changes on.

[usmanmuhd]

I am currently very busy with assessments so not being able to do this. I will stop work so that it will open up to other people. I hope that my work done till now will help the next bounty hunter.

[gitcoinbot]

💰 A crowdfund contribution worth 0.50000 ETH (53.85 USD @ $107.7/ETH) has been attached to this funded issue from @ceresstation.💰

Want to chip in also? Add your own contribution here.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 3 months, 3 weeks ago.
Please review their action plans below:

1) pinkiebell has started work.

I will submit a pull request before weekend :)

Learn more on the Gitcoin Issue Details page.

[pinkiebell]

So, I need someone to test kudos :)
It seems syncing kudos easily locally is still on the roadmap 🤣

[owocki]

theres some docs on how to get local kudos minted over at https://github.com/gitcoinco/web/blob/master/docs/KUDOS.md#how-do-i-gettest-kudos-on-my-local-rpc-node

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 0.5 ETH (72.98 USD @ $145.96/ETH) has been submitted by__:

1. @pinkiebell

@owocki please take a look at the submitted work:

• PR by @pinkiebell

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $47,198.84 more funded OSS Work available on the Gitcoin Issue Explorer

[rmshea]

@owocki looks like this one is ready to be reviewed :)

[owocki]

thanks.. looking now

[rmshea]

@owocki any thoughts here?

[owocki]

i agree it needs to be reviewed / regression tested by the core team

[ceresstation]

@owocki any updates on this one?

[owocki]

Pr still needs review; I'd suggest getting with product / engineering to set aside time to cleanout the PR backlog (includign this one)

[kuhnchris]

@owocki @ceresstation can we still check this out or shall we kill it? Funds for @pinkiebell are also still floating around. Thanks

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 0.5 ETH (91.27 USD @ $182.55/ETH) (plus a crowdfund of 0.5 ETH worth 91.27385535 USD) attached to this issue has been approved & issued to @pinkiebell.__

Thanks to @ceresstation for their crowdfunded contributions to this bounty.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $80,452.56 more funded OSS Work available on the Gitcoin Issue Explorer