Web: Build - Resurface Issue To the top when Expiration has been Extended

Created on 10 Sep 2018  Β·  30Comments  Β·  Source: gitcoinco/web

Description

As a user I want to see issues at the top If no one has started work and the expiration has been extended.

Definiton of Done

  • [ ] Build in logic to make an issue refresh and display at the top of the issue explorer if the issue time frame has been extended.

Please review with @pixelantdesign @vs77bb

Gitcoin Issue Explorer OKR enhancement medium

All 30 comments

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 0.17 ETH (33.48 USD @ $196.96/ETH) attached to it.__

@mul1sh let us know if you have questions!

@willsputra this is related to what you're designing!

@PixelantDesign will do, πŸ™‚ thanks

@PixelantDesign between newly created issues and issues where the expiration has been extended, which should take the highest precedent i.e. should newly created issues appear higher in the list than the extended expiration or vice versa?

@mul1sh Let's order it based on time.

Example:
If I create a new issue and then I extend an expiration on a different issue.
The extended expiration should go to the top.

It would be great if we could give the recently updated items a color overlay and fade it out after 5-10 seconds after the page loads using this color #ECF5FF. See below.

screen shot 2018-09-14 at 6 36 37 am

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__The funding of this issue was increased to 0.4 ETH (82.62 USD @ $206.54/ETH) .__

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__The funding of this issue was increased to 0.4 ETH (82.62 USD @ $206.54/ETH) .__

@PixelantDesign thanks for the feedback πŸ™‚ , implementing it like this then

@mul1sh Excited to see what you come up with here!

@mul1sh Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an β€˜Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot just finishing testing my changes and then I commit in less than 5 hours πŸ˜„

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work for 0.4 ETH (83.32 USD @ $208.3/ETH) has been submitted by__:

  1. @mul1sh

@PixelantDesign please take a look at the submitted work:

  • PR by @mul1sh

Hey @PixelantDesign, looks like @mul1sh has submitted and is ready to be reviewed. :)

Thanks for the reminder @ryan-shea

@mbeacom good to pay this out?

@PixelantDesign sorry for closing but i've re-opened the PR here again https://github.com/gitcoinco/web/pull/2279

Hi @mul1sh how is this going?

@PixelantDesign also wrapping it up now, thanks

Thanks @mul1sh, would it be possible to try to get this merged in the next day or so?

cc @SaptakS for pr review when it's ready.

@PixelantDesign yes it is, I've made the required changes to the PR, so i'm basically re-basing it with master and fixing the merge conflicts and then I push it for review

Thanks!

Looks like the PR needs adjustments based on @pinkiebell's review comments and the merge conflicts resolved.

Then it should be ready for final review/merge.

@mbeacom yeah true πŸ™‚, though i'm having a some issues sorting the conflicts after a rebase master, in fact thats the only thing holding me back now. So once i do a clean rebase i'll update this PR.

The PR was closed, is there a new PR we should track @mul1sh?

@PixelantDesign I re-opened the PR here #2279 sometime back, so i've been trying to sort out the merge conflicts and then i push it for review

Thanks for the update @mul1sh, would it be possible to get the conflicts resolved by early next week?
cc: @pinkiebell

Closing this since we're mostly working on the PR now.

@PixelantDesign sure I intend to actually get the conflicts fixed today

Closing this since we're mostly working on the PR now.

Ok cool, i'll alert you in the PR to test when its ready

@PixelantDesign did this got reopend on purpose?

Ah @kuhnchris I guess this was opened on 21st July!
This has been fixed over at https://github.com/gitcoinco/web/pull/5012

This is duplicate issue https://github.com/gitcoinco/web/issues/4744 (well the other one is the duplicate but yeah )

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kuhnchris picture kuhnchris  Β·  4Comments

frankchen07 picture frankchen07  Β·  4Comments

jasonrhaas picture jasonrhaas  Β·  4Comments

NukeManDan picture NukeManDan  Β·  3Comments

kziemianek picture kziemianek  Β·  3Comments