Web: Advanced Payout --> Incorrect Stats / Gitcoin Bot Comments

[vs77bb]

Describe the bug
When using the Advanced Payout feature, Gitcoin Bot does not recognize that a % of the bounty was paid out, as opposed to the whole bounty.

To Reproduce
See here. I paid out 70% of the bounty, but Gitcoin Bot still shows as if I paid the whole thing. It also still shows 350 DAI as the 'Work Done' amount, though I paid out only 245 DAI.

Expected behavior
Provide the actual amount paid out on a) Gitcoin, b) Gitcoin Bot's comment on Github, and c) anywhere else it is needed.

[owocki]

recomend pivoting the 'work done' comment from gitcoin bot based upon whether it was an advanced payout or not... and customizing the message if so.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $26,836.97 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[vs77bb]

@usmanmuhd thanks for picking this up. Let us know if you have any Q's!

[usmanmuhd]

Sure @vs77bb .

[gitcoinbot]

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[usmanmuhd]

Hey @vs77bb . I am not able to get the bot working in my local instance. It says to locate a .pem file and also id for the gitcoinbot app, both of which I am not able to locate. Could you please help me with this?

[vs77bb]

@usmanmuhd is this still an issue on your side?

If so -- @SaptakS @thelostone-mc @mbeacom , would you be able to help out @usmanmuhd here?

[usmanmuhd]

@vs77bb yes it is still an issue.

[owocki]

@usmanmuhd did you go through the integration guide for github? see https://docs.gitcoin.co/mk_third_party_integrations/

if so, and you're still having issues, can you open up a github issue for this bug report and please include the exception you're getting back? we'd be happy to help ?

[usmanmuhd]

From the bot details, I am not able to get the following details

GITCOINBOT_APP_ID=7735  # Gitcoin Bot App ID
GITCOIN_BOT_CERT_PATH=app/gitcoin_bot_secret.pem  # If pem file is located at web/app/app/gitcoin_bot_secret.pem

1. What is the app id? (I have attached a screenshot of the page, it shows no id as such)
2. Where is the gitcoin_bot_secret.pem file?
   

[thelostone-mc]

@usmanmuhd until that gets resolved -> you can still log the response of the bot at notifications.py on the terminal when you recreate the scenario.
This is so that you aren't blocked by this issue

[usmanmuhd]

@thelostone-mc get-notifications.py seems to throw errors because the django.conf.settings is not getting set when I directly run the file. Changing it in one place does not seem to fix it. There are many other files that need a change. I think it's better for me to wait for this to resolve. @vs77bb @owocki @SaptakS Is there any way to directly just see the gitcoin bot notifications than this one?

[owocki]

@usmanmuhd you need to create your own github app for testing purposes.. we aren't going to give you access to the production gitcoinbot app.

i dont think you'll need to set GITCOIN_BOT_CERT_PATH for testing the gitcoinbot comments in this use case.. just set it to Falsy for now

@mbeacom maybe its worth updating the documentation to point users to to where they can get the bot id or app id?

[thelostone-mc]

@usmanmuhd on the off chance you decide to give it a shot! you'd have to move build_github_notification to L532 to ensure the message build up happens first.

That's kinda what I did here

[usmanmuhd]

Thanks @thelostone-mc ! It works!

[usmanmuhd]

How do we know in the notifications.py while triggering the bot that we have checked out using advanced payout option?

[owocki]

How do we know in the notifications.py while triggering the bot that we have checked out using advanced payout option?

i'm not sure i understand the question.

[usmanmuhd]

I mean when the bot is triggered when the payment is made. How does it know if we have checked out using the basic payout option or the advanced payout option?

[owocki]

the frontend tells th backend it has been paid via the /sync/web3 url route

there are also management commands that will check for changes to the smart contracts:

• sync_web3
• sync_listener

[gitcoinbot]

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@usmanmuhd due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] warning (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[usmanmuhd]

I am not able to get the docker to work. When I run docker-compose up --build I get the error https://pastebin.com/pSMc7sJz

[owocki]

per gitcoin slack, @mbeacom put a fix for this into the latest gitcoinco/master !

[gitcoinbot]

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[thelostone-mc]

@usmanmuhd still having trouble with docker?

[usmanmuhd]

@thelostone-mc It is resolved. I am figuring out ways to know in the back end, the ways to differentiate between a basic payout and advanced payout.

[gitcoinbot]

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@usmanmuhd due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] warning (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 10 months, 1 week from now.
Please review their action plans below:

1) pinkiebell has started work.

I'm picking this up. Should be ready later today

Learn more on the Gitcoin Issue Details page.

[pinkiebell]

@vs77bb
As the bounty actually got killed and you instead sent a tip (That's how it works),
we need another copy for a 'Bounty is Done but we have no fulfillments'.
😅 Ideas?

cc @PixelantDesign

[pinkiebell]

@vs77bb
Thoughts?

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This Bounty has been completed.__

Additional Tips for this Bounty:

• pinkiebell tipped 0.0100 ETH worth 2.29 USD to pinkiebell.
• pinkiebell tipped 0.0100 ETH worth 2.29 USD to pinkiebell.
• pinkiebell tipped 0.0100 ETH worth 2.29 USD to pinkiebell.
• pinkiebell tipped 0.7000 ETH worth 160.62 USD to pinkiebell.

---

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $101,446.87 more funded OSS Work available on the Gitcoin Issue Explorer

[rmshea]

Hey @pinkiebell, Ryan from Gitcoin. Want to let you know that @vs77bb and the rest of the Gitcoin team have been busy with travel, and will get to look at this soon 😄 If you have any questions, feel free to ping me in Slack! I'm rshea. 🔨

[vs77bb]

@pinkiebell

Bounty is Done but we have no fulfillments

I'm not sure I understand when this can happen 🤔

[pinkiebell]

@vs77bb

Well, the advanced payout feature does kill the bounty and will use the tip system to disburse payments.

We just save it as Work Done not Killed.
That means a bounty can be successfully marked as Done without even someone submitted work.

Snippet from Gitcoin.cli (Dead = Killed)

bounty 741
Project Type: traditional
Permission Type: permissionless
Status: Dead
Platform: gitcoin
Title: Add option to include transaction receipts in eth_getBlockByHash
Funder: vs77bb/0x60206c1F2B51Ac470cB0f71323474f7f9e4772e1
Token: 350 DAI
Available Balance: 0 DAI
Fulfillments: 0

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 50.0 DAI (50.0 USD @ $1.0/DAI) has been submitted by__:

1. @pinkiebell

@owocki please take a look at the submitted work:

• PR by @pinkiebell

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $54,675.40 more funded OSS Work available on the Gitcoin Issue Explorer

[rmshea]

@vs77bb @owocki not sure what the status is on this one !

[pinkiebell]

@ryan-shea @kuhnchris

I got an email that the issue is expiring, care to close this thing on gitcoin? :)
PR:https://github.com/gitcoinco/web/pull/2507
Gitcoin: https://gitcoin.co/issue/gitcoinco/web/2125/1095

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @pinkiebell.__

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Chat
• $709,346.96 more funded OSS Work available on the Gitcoin Issue Explorer