Web: Create "Grants Pending" Page - Design + Code

Created on 1 Aug 2018  路  15Comments  路  Source: gitcoinco/web

User Story

As a Grants user, I want a screen to let me know when my transaction is pending on-chain so I know that I have submitted my grant but it has not been successfully written yet.

Why Is this Needed

The "Grants Pending" page is needed to inform the user of the state of their transaction and to let them know that their grant is not active yet.

Description

Type: Feature

Definition of Done

  • [x] Replicate the "Pending" page for bounties with Grants Copy
  • [x] Page has standard Gitcoin header and footer
  • [x] Design must be on brand, see creative repo for brand guide

Additional Information

To be reviewed with @PixelantDesign @mbeacom @captnseagraves

Existing assets can be found at this PR: https://github.com/gitcoinco/web/pull/674
More information about the Dev Grants project can be found here: https://github.com/gitcoinco/web/issues/1469

Please allow the core team a few rounds of revisions.

frontend grants

Most helpful comment

@captnseagraves We can put the same one right? I will put them there too. :)

All 15 comments

Assigning @justpixel

note: we could reuse the bounty pending page, so i think this is lower priority than the others

I agree on reusing the bounty pending page here.

Sounds like we are just going to replicate and change a little bit of copy

yep!

We'll be porting over the waiting state as is from bounty.
How it would work -> Once a grant is created , we display the waiting state until the txn has been confirmed

@SaptakS has got a PR out for this. Only thing left is to handle for web3js version 1.0.0

Assigning this to myself and @SaptakS ^_^

We'll be porting over the waiting state as is from bounty.

+1 for anything that refactors bounty_details.js to be smaller :)

@thelostone-mc Sounds good to me! We will also need the waiting state on "Fund grant" and "Cancel Subscription". It should be the same as implementing here, but at slightly different points in the transaction. just a matter of where to insert in the .js. I'll write up a separate ticket for it. :)

@captnseagraves yeah we'll add it in there.
@SaptakS would it make sense to spin up a new ticket and handle it all in one ticket ?

@thelostone-mc @SaptakS We can handle it all here. I'm happy to implement today as well, if you haven't begun to move on it.

@captnseagraves these page is already implemented and there in the grants page. Can you please check. There is a waiting state page after creation of grants.

@SaptakS Yes, the waiting state is done for grants/new. Thank you! There are two other points in the application where we send transactions to the blockchain. In the "Fund Grant" view and the "Cancel Subscription" view. These also need a waiting state.

@captnseagraves We can put the same one right? I will put them there too. :)

@SaptakS Yes! Same one should be good.

Closing this out ad @SaptakS has already wired this in

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kuhnchris picture kuhnchris  路  4Comments

abitrolly picture abitrolly  路  4Comments

sethmcleod picture sethmcleod  路  4Comments

uluhonolulu picture uluhonolulu  路  3Comments

kziemianek picture kziemianek  路  3Comments