Web: Associate PR to Existing Open Issue

[PixelantDesign]

User Story

As a Contributor I'd like for Gitcoin Bot to be smart and know that a PR I submit is related to an open issue that I've committed to.

Why Is this Needed

Summary: No detection now

Description

Type:Feature

Expected Behavior

When a user creates a pr, it would be nice if Gitcoin bot knew or asked if you want to associate the pr with an open issue you're working on.

Definition of Done

• [ ] Review the work that has been done on this ticket
• [ ] Fix the problem or propose a new tech approach
• [ ] Once a contributor has started and associated a PR to an issue, the Gitcoin Bot should recognize that updates are being made on the PR.
• [ ] Make Gitcoin Bot update the original Github issue somehow and also denoting activity on the PR. Feel free to brainstorm with the core team here.
• [ ] Review with core team members @pixelandesign @mbeacom @SaptakS

[PixelantDesign]

@darkdarkdragon any thoughts on this?

[mbeacom]

We have this coded up and it worked at one point: https://github.com/gitcoinco/web/pull/458
Something seems to have broken it a while back. It needs debugged and fixed.

[owocki]

right now you can attach a PR when you submit work and that is linked in gitcoinbot's subsequent comments about the submission. but i think this ticket is in regards to some other part of the flow?

[darkdarkdragon]

@owocki after submitting pr discussion usually moves to the pr, but gitcoin bot doesn't pick that up and issues inactivity warnings to the issue thread

[darkdarkdragon]

@mbeacom from reading code in pr #458 looks like it doesn't pickup comments in the pr thread

[owocki]

I thought that on #458 we were using the timeline API (which should pick up related PRs).

From the PR

Uses the GitHub timeline API to detect various types of activity on a given issue performed by the interested party.

In any case, I agree this shoudl be fixed. It'd be helpful to have an example of a bounty (and associated PR) where it has not been working in prod to debug.

[PixelantDesign]

@mbeacom @owocki should we bounty this?

[owocki]

yes agree

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.22 ETH (89.56 USD @ $407.11/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $25,395.00 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__Work has been started__.

These users each claimed they can complete the work by 1 month, 1 week ago.
Please review their action plans below:

1) darkdarkdragon has been approved to start work.

need to simulate this situation on test accounts first, and check what info github api returns

Learn more on the Gitcoin Issue Details page.

[darkdarkdragon]

@PixelantDesign @owocki ok, I've tested current code - created a bunch of issues, pull requests and comments. Current code works correctly, it pickups comments from pull requests.
It will not pickup activity related to issue only in case that no one will reference bounty's issue in pr/comment to pr. We can solve this by going trough submitted prs and picking activity from them too, but don't think this worth the effort.
So this issue can be closed.

[owocki]

thanks for the investigatory work!

[darkdarkdragon]

@owocki np. good to see this working. I remember this was a problem for me back in the days

[gitcoinbot]

@darkdarkdragon Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[frankchen07]

hey @darkdarkdragon, how it going on this issue? It looks like you said this issue can be closed after some exploratory work. Was there a code/bug fix or a PR that ensures that this problem is fixed?

[darkdarkdragon]

@frankchen07 code that is already in repository already covers the problem raised in this issue

[frankchen07]

So it sounds like to me that the current code encompasses:

1. Gitcoin bot picks on a linked PR
2. Gitcoin bot picks up comments on PRs
3. Gitcoin bot does NOT pick up comments on PRs when the original issue is not referenced in the PR - and based on your exploration it's a high manual effort that isn't worth it.

Does this sound correct @darkdarkdragon?

@owocki & @PixelantDesign - if the conclusions above are fitting, perhaps payout and closure is in store, unless we'd like to extend the bounty.

[darkdarkdragon]

@frankchen07 Yest, it's right. For 3 - we can make bot to go through all the submitted PRs, but don't think it worth it, because any mention of original issue in the comments thread of PR will allow bot to pick up activity from that thread.

[owocki]

yes thats right

[mbeacom]

@darkdarkdragon I'm looking into the bot timeline activity checks a bit. I think it's only worth checking associated PRs. I think it's worthwhile to check PRs that are referenced in submit work step. I think that's what we were looking for with the original issue. As a Contributor I'd like for Gitcoin Bot to be smart and know that a PR I submit is related to an open issue that I've committed to. - Ideally, a user references the original GH issue when submitting a PR. If they don't happen to do that, they usually include the PR URL along with their Gitcoin submission. We should be checking the submitted PR URLs for activity as well - This requires checking the user the PR and if it matches the user in the active bot iteration, handle the activity on the associated PR like we do for other checks. Do you want to code that up or should we pass it back to the crowd?

[darkdarkdragon]

@mbeacom Ok, if you think it's worthwhile, I'll do.
btw, I remember that I've pressed 'stop work' on this issue after bot warned me about inactivity. But now I see it didn't worked...

[PixelantDesign]

Thanks @darkdarkdragon I'll document as a bug.

[darkdarkdragon]

@mbeacom while writing the, I've found out that it doesn't issue warnings if bounty in 'submitted' state (previously it was doing so, but while ago submitted bounties was removed from check)
so all this conversions doesn't make sense - there is just no warnings for bounties that has submitted work
https://github.com/gitcoinco/web/blob/268f40b37efb6e08ed0b0a1a4efc6a3252bc278a/app/marketing/management/commands/expiration_start_work.py#L77-L82

[frankchen07]

@darkdarkdragon - so it sounds like we previously removed checks from submitted bounties, and you're wondering on how to proceed.

One option, based on @mbeacom's comment is to add the checks back in for submitted work, and then proceed, although I don't have context for for why it was removed in the first place (maybe @mbeacom can give reasoning for that, so we can explore our options).

[frankchen07]

Following up on this ticket - will need @mbeacom's input. (@vs77bb to help follow up while I'm out).

[gitcoinbot]

@darkdarkdragon Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[PixelantDesign]

@darkdarkdragon are you still working on this?

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@darkdarkdragon due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] warning (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[darkdarkdragon]

@PixelantDesign I was waiting on @mbeacom's response on this one, but probably there is just nothing to do here

[PixelantDesign]

@mbeacom ^

[frankchen07]

@mbeacom - check out darkdarkdragon's comment on August 23rd - it seems like the work that is meant to be done on checks for submitted bounties isn't possible if there isn't a check on submitted bounties.

Possible options:

1. Add the checks back in and have darkdarkdragon proceed.
2. Nothing else to do here.
3. Your recommendation.

[rmshea]

Hey @mbeacom, wanted to bump this thread. Can you check out @darkdarkdragon's comment?

@darkdarkdragon, we've had a busy month of travel and prep for feature launches. Sorry for the tardiness on our end with this one.

[kuhnchris]

As we need to reassign some of Mark's older topics, we'll need to have someone take this over. @ryan-shea who shall we assign this to?
Thanks @darkdarkdragon for being patient with us, as we are trying to figure this out!

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__The funding of 0.22 ETH (23.98 USD @ $108.98/ETH) attached to this issue has been cancelled by the bounty submitter__

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $53,859.95 more funded OSS Work available on the Gitcoin Issue Explorer