Web: Frontend Coding Advanced Payout Feature

Created on 11 Jun 2018  ·  36Comments  ·  Source: gitcoinco/web

FRONT END CODING TASK

User Story

As a funder of Cooperative/Contest, I want a Bulk Payout Feature, since Cooperative/Contest Bounties don't have that currently and it'd be way more convenient.

Why Is this Needed?

Summary:
Because paying out competitive and contest blounties is way too cumbersome now.

Description

Type:
Feature

Current Behavior

Legacy Accept Flow

Expected Behavior

  1. When a bounty that is Cooperative/Contest bounty, the accept button will be replaced with a 'payout bounty' button.

screen_shot_2018-06-10_at_7_30_56_pm

  1. when i click that button, ill be presented with a form that allows me to payout the bounty to n number of github usernames (or ether addresses).

screen shot 2018-06-10 at 7 40 47 pm

html of this form, download link

the form will auto complete the 'amount' field based upon the percentages.
the form will grey out the 'payout' button until all fields add up to 100% exactly

This form will validate

  1. that the percentages in leftmost column add up to 100%
  2. all github usernames and ether addresses are valid

Upon submission,

  1. the bounty will be canceled in standard bounties (since StandardBounties doesnt contain functionality for multiple payouts as we need -- see https://github.com/gitcoinco/web/issues/1379 and https://github.com/gitcoinco/web/issues/1380 )
  2. the bounty will be marked as 'done' on gitcoin
  3. several new tips will be created on behalf of the funding user to payout each of the above amounts.

this may result in multiple metamask confirmations and the user should be prompted as we explain what we're doing.

Bounty

this is a bounty for the frontend coding of this interface. That means that youll be creating the links to the form from the bounty detail page AND the bulk form html / js itself, but not doing any of the heavy lifting around actually transmitting the tokens to the blockchain.

please only start work in this if you can get a WIP PR in within 24 hours and finish the task within 7 days.

community member

Most helpful comment

The contributor would still click to submit the work correct?

Interesting comment about this on the Gitcoin slack

But brings up a question: If I see that I am likely not going to win a contest bounty, why pay gas to submit work? :thinking_face: So I would start work and wait and see if I am even close in the running before submitting work, right? Is that a bug or a feature of this new system? (edited)

Will a funder always want to pay all coops at once? Will we allow breaking up of payment (a funder to pay for just 2 of the 4 co-op participants)?

I'm not sure they will... we can either (1) build this first and then iterate towards multi bulk payouts or (2) add that scope to this ticket

All 36 comments

@PixelantDesign thoughts on this?

This is very useful and could be applied to splitting bounties on non/co op project types.

The contributor would still click to submit the work correct?

When a funder clicks Payout Bounty - will he/she see the work submission (and note) that was provided by each co-op participant? Or is the funder only concerned about paying out at this point?

I think it's nice to see submissions from each participant and show the payment form below...thoughts?

Will a funder always want to pay all coops at once? Will we allow breaking up of payment (a funder to pay for just 2 of the 4 co-op participants)?

The contributor would still click to submit the work correct?

Interesting comment about this on the Gitcoin slack

But brings up a question: If I see that I am likely not going to win a contest bounty, why pay gas to submit work? :thinking_face: So I would start work and wait and see if I am even close in the running before submitting work, right? Is that a bug or a feature of this new system? (edited)

Will a funder always want to pay all coops at once? Will we allow breaking up of payment (a funder to pay for just 2 of the 4 co-op participants)?

I'm not sure they will... we can either (1) build this first and then iterate towards multi bulk payouts or (2) add that scope to this ticket

I figure that as a bounty hunter this is a good thing - as I save gas if I wait to see if I have a chance at winning a competition. But in what cases is this an issue for funders? As I would need to get close to a full solution/ completion anyway to be in the running.

More fundamentally though - if I do the work on a funded issue, all I need to do is provide my address to a funder right? Why does it need to be on a smart contract? Just have the funder plug that directly into the contract to payout so you never need to pay as a bounty hunter to submit work. This seems like a better way to get people on-boarded for sure. No need for eth to be paid for a bounty. Am I missing something?

@NukeManDan thanks for your comments.. i think mbeylin and you chatted about this on slack right?

@PixelantDesign any objections if i fund the creation of this form via a bounty?

@owocki

That is an interesting point, though having participated in coops myself, I think once the person has done the work, they've committed to entering, no? What's a little bit of gas if you've already put in the effort?Perhaps it depends on what the task is.

I think building the form out to pay out all at once to see if we get traction on it makes sense.

Let's bounty it!
I would just ask that the developer uses existing form styles currently used on the new fund issue form. or reference UI toolkit on the creative repo.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.__

@phyroxin just shot you over an approval. looking forward to working with ya!

and to answer your questions.. no special requirments.. theres repo spin up instructions at https://github.com/gitcoinco/web/

@phyroxin Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Yes I'm still working on it. I had to resolve an issue with running a
version of the site locally on windows 7 using docker. I'm currently
seeking more information on the issue.

On 16 June 2018 at 17:15, Gitcoin.co Bot notifications@github.com wrote:

@phyroxin https://github.com/phyroxin Hello from Gitcoin Core - are you
still working on this issue? Please submit a WIP PR or comment back within
the next 3 days or you will be removed from this ticket and it will be
returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day
https://gitcoin.co/issue/gitcoinco/web/1422/606?snooze=1 | 3 days
https://gitcoin.co/issue/gitcoinco/web/1422/606?snooze=3 | 5 days
https://gitcoin.co/issue/gitcoinco/web/1422/606?snooze=5 | 10 days
https://gitcoin.co/issue/gitcoinco/web/1422/606?snooze=10 | 100 days
https://gitcoin.co/issue/gitcoinco/web/1422/606?snooze=100


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/1422#issuecomment-397822958, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEB-qrzpczB2-E1smcaA_7w6FfMfhltIks5t9S8xgaJpZM4Uh9js
.

I completed work on https://gitcoin.co/issue/gitcoinco/web/1422/606. I don't find out how to put my code. Please help.

I put code on github, https://github.com/snezanasucurovic/snezanalounge1
I hope it is enough.

@snezanasucurovic this issue was claimed by @phyroxin -- thats why you can't claim the issue on gitcoin.

@phyroxin what do you want to do here? depending upon how far along you are... you could release the issue or continue working on it. i'd also be happy to split the payout between both of ya

cc @PixelantDesign -- this is interesting.. its the first case of someone doing work while another person had claimed the bounty (since we launched the project types PR)

I'll let this go in this instance and let @snezanasucurovic
https://github.com/snezanasucurovic claim it. No point duplicating the
work already done. Obviously I don't want this to affect my record ( which
is essentially at 0 as this was my first bounty ). I can move onto another.

Kind Regards,

Lamin

On 18 June 2018 at 17:18, Kevin Owocki notifications@github.com wrote:

cc @PixelantDesign https://github.com/PixelantDesign -- this is
interesting.. its the first case of someone doing work while another person
had claimed the bounty (since we launched the project types PR)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/1422#issuecomment-398111102, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEB-qj6C_QtuuhSQAk9fK674Mzt5gF3cks5t99LpgaJpZM4Uh9js
.

Dear Sir,
as you can see my English is not brilliant. I am not sure what should be my
next step.
Kind regards,
Snezana Suciurovic

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Mon, Jun 18, 2018 at 6:34 PM, Lamin Camps notifications@github.com
wrote:

I'll let this go in this instance and let @snezanasucurovic
https://github.com/snezanasucurovic claim it. No point duplicating the
work already done. Obviously I don't want this to affect my record ( which
is essentially at 0 as this was my first bounty ). I can move onto another.

Kind Regards,

Lamin

On 18 June 2018 at 17:18, Kevin Owocki notifications@github.com wrote:

cc @PixelantDesign https://github.com/PixelantDesign -- this is
interesting.. its the first case of someone doing work while another
person
had claimed the bounty (since we launched the project types PR)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/1422#issuecomment-398111102,
or mute
the thread
QtuuhSQAk9fK674Mzt5gF3cks5t99LpgaJpZM4Uh9js>
.

>


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/1422#issuecomment-398116029, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Akg9oAn0rPhoGooHgknZeJfrSsO3UvfPks5t99aegaJpZM4Uh9js
.

Hi @snezanasucurovic, please go here to click 'Start Work' on the bounty. If you believe it's ready for submission, you may also 'Submit Work'. If you need a bit of ETH to do so, please reference the Gitcoin Faucet

@phyroxin Thank you for your understanding in this scenario and for being a team player. While we removed you from the bounty, it did not count in any way against your record. We hope you find something else to work and please let us know if you have any questions!

No worries, glad to be of help :)

On 18 June 2018 at 21:14, Vivek Singh notifications@github.com wrote:

Hi @snezanasucurovic https://github.com/snezanasucurovic, please go
here to click 'Start Work'
https://gitcoin.co/issue/gitcoinco/web/1422/606 on the bounty. If you
believe it's ready for submission, you may also 'Submit Work'. If you need
a bit of ETH to do so, please reference the Gitcoin Faucet
http://gitcoin.co/faucet

@phyroxin https://github.com/phyroxin Thank you for your understanding
in this scenario and for being a team player. While we removed you from the
bounty, it did not count in any way against your record. We hope you find
something else to work and please let us know if you have any questions!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/1422#issuecomment-398180929, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEB-qpkEO_o4vbb-2PEe6VELvsW03KGfks5t-Ao7gaJpZM4Uh9js
.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work has been started__.

These users each claimed they can complete the work by 8 months, 3 weeks ago.
Please review their action plans below:

1) snezanasucurovic has been approved to start work.

I think I can submit code. I will change it according to comments.

Learn more on the Gitcoin Issue Details page.

Dear Sir,
I corrected code for Add Row and Payout buttons. Do I understand ? Am I expected to correct other code ?
Kind regards,
Snezana

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by__:

  1. @snezanasucurovic

@owocki please take a look at the submitted work:

  • (Link Not Provided) by @snezanasucurovic

While I was submitting work I forgot to place link. Here it is https://github.com/snezanasucurovic/snezanalounge1 and file is HTMLVer2Sucurovic.html. I am not comfortable with version control systems.
Kind regards,
Snezana

@snezanasucurovic you would have to integrate this code into this repo! add your changes on top of that so that we can check it out

Check out https://git-scm.com/videos -> they've got decent how to use git
To set up the repo : https://github.com/gitcoinco/web#running-locally

Thank you for email and possibility for me to work great things.
Kind regards,
Snezana

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Mon, Jun 25, 2018 at 5:15 PM, Aditya Anand M C notifications@github.com
wrote:

@snezanasucurovic https://github.com/snezanasucurovic you would have to
integrate this code into this repo! add your changes on top of that so that
we can check it out

Check out https://git-scm.com/videos -> they've got decent how to use git
To set up the repo : https://github.com/gitcoinco/web#running-locally


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/1422#issuecomment-399988122, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Akg9oDmxx1KGvxBX6G456hjz6-03f1cbks5uAP6hgaJpZM4Uh9js
.

@snezanasucurovic Thank you for your contribution!

Can you migrate this into our repository gitcoinco/web? We'll need your existing implementation migrated from .html files to populate data from the Django backend and rendered via the Django templating engine.

You can take a look at: https://github.com/gitcoinco/web/tree/master/app/dashboard/templates for more examples of how our model/view/template/controller flow is handled.

Feel free to reach out to us directly on slack or on this issue for further assistance or clarification.

You can get started by setting up the local test environment as outlined in:

https://github.com/gitcoinco/web/blob/master/docs/RUNNING_LOCALLY_DOCKER.md

Dear Sir,
I am not in my workplace now. I will be there at 07.07.2018. Sorry about
that.
Kind regards,
Snezana

sre, 27. jun 2018. 20.31 Mark Beacom notifications@github.com је
написао/ла:

@snezanasucurovic https://github.com/snezanasucurovic Thank you for
your contribution!

Can you migrate this into our repository gitcoinco/web? We'll need your
existing implementation migrated from .html files to populate data from
the Django backend and rendered via the Django templating engine.

You can take a look at:
https://github.com/gitcoinco/web/tree/master/app/dashboard/templates for
more examples of how our model/view/template/controller flow is handled.

Feel free to reach out to us directly on slack https://slack.gitcoin.co
or on this issue for further assistance or clarification.

You can get started by setting up the local test environment as outlined
in:

https://github.com/gitcoinco/web/blob/master/docs/RUNNING_LOCALLY_DOCKER.md


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/1422#issuecomment-400784939, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Akg9oF_qqBaCIz_quGO1Ts3MDCvhof-Tks5uA89sgaJpZM4Uh9js
.

@snezanasucurovic welcome back :) mind taking a look now that youre back at the office?

Hi Kevin, thank you for kind words, i will do my best.

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Fri, Jul 6, 2018 at 10:26 PM, Kevin Owocki notifications@github.com
wrote:

@snezanasucurovic https://github.com/snezanasucurovic welcome back :)
mind taking a look now that youre back at the office?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/1422#issuecomment-403138134, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Akg9oPYIbjASKGR-wM_2hEqirIv-bgc9ks5uD8fogaJpZM4Uh9js
.

Hi, i need a few days to start programming in Python(by use Microsoft
Visual Studio Code) and use Django. I hope that it is not problem.Snezana

On Sat, Jul 7, 2018 at 2:02 PM, Snezana Sucurovic <
[email protected]> wrote:

Hi Kevin, thank you for kind words, i will do my best.

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#m_4228338042259588382_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Fri, Jul 6, 2018 at 10:26 PM, Kevin Owocki notifications@github.com
wrote:

@snezanasucurovic https://github.com/snezanasucurovic welcome back :)
mind taking a look now that youre back at the office?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/1422#issuecomment-403138134,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Akg9oPYIbjASKGR-wM_2hEqirIv-bgc9ks5uD8fogaJpZM4Uh9js
.

@snezanasucurovic i'm just going to use the code as is. need this for the above PR and can't wait for you to get the repo spun up. thanks!

@owocki can we close this one out or are you still looking for this to be done at some point?

⚡️ A tip worth 50.00000 DAI (50.0 USD @ $1.0/DAI) has been granted to @snezanasucurovic for this issue. ⚡️

Nice work @snezanasucurovic! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been approved & issued.__

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ghost picture ghost  ·  3Comments

christianbundy picture christianbundy  ·  3Comments

NukeManDan picture NukeManDan  ·  3Comments

kziemianek picture kziemianek  ·  3Comments

thelostone-mc picture thelostone-mc  ·  4Comments