Web: quarterly stats v2 - mobile first view

Created on 17 May 2018  Â·  46Comments  Â·  Source: gitcoinco/web

Description

make email mobile first view

The base skeleton is already set up @ https://github.com/gitcoinco/web/pull/1016

Issue: Since the styles are being converted inline -> media queries don't get applied cause the mobile view breakdown

Solution : Rewrite the html skeleton to make the quarterly stats mobile first

must be compatible with

https://github.com/gitcoinco/web/issues/1036

Due By

Must be merged by the end of June 2018.

core team frontend

Most helpful comment

@frankchen07 I am interested in doing this, but I have 2 other issues of high priority currently going on. Will take this up once I complete those 2.

All 46 comments

another v2 ticket, which ill bounty the scope of....

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 0.1 ETH (52.35 USD @ $523.54/ETH) attached to it.__

@thelostone-mc & @owocki Is this going to be a webpage that you can view in the browser, if unable to view on mobile/email client?

@Elaniobro i wasnt planning on doing that.. i was just planning on making it mobile compatible in email client

@sthorpe welcome! glad to have you on this. wanna submit a WIP PR when you get started? hopefully in the next day or so

@owocki Yup. Do you have a format for our WIPs? I'm gonna get started today. Awww never mind. I found it.

no format -- just put WIP in the PR title

@sthorpe Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Hi @sthorpe how is it going here?

@vs77bb Hey there! Yes, been distracted with other things lately. I'm back on today.

@sthorpe Thanks! Feel free to reach out to us on Slack if you have any questions!

@sthorpe Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@sthorpe due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] warning (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@rafaelboyero Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@rafaelboyero Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@owocki Can you tell me how can I test the email? I want to make some changes and then test if they are working.

@shad-k When you mean test -> you mean just rendering it / actually sending the mail ?
If it's the former - > create a super user (admin) in django and visit the email url defined urls.py and login as the super user

what @thelostone-mc said

@shad-k Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@shad-k due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] warning (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Sorry, i got distracted with some other things. Will continue working on this and put in a PR by the end of this week.

@shad-k Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@shad-k due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] warning (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@shad-k @thelostone-mc @owocki Should we send this one back out to the crowd?

@vs77bb I guess it's already out in the open issues since I clicked on Stop Work on gitcoin 7 days ago.

@thelostone-mc @PixelantDesign should we remarket this one / extend the deadline? Know we're still waiting on that feature 🙂

Extending issue is complete. We will deploy Monday. @vs77bb @SaptakS

Maybe remarket to see if anyone picks up this weekend?

Is this still something that needs to be done? The issue is open but deadline is in the past. Not sure if this needs to be picked up.

@alp82 yeah have at it ! we'd be happy to tip you out / reopen the bounty if you can get it across the finish line

@thelostone-mc is this open?

Ah I think @owocki did push out an update on this! 😅
@owocki do we have anything which needs to be done ?

email could def use some cleanup.. .i just did a quick hackjob

@usmanmuhd looks like it's up for grabs ^_^

@thelostone-mc Cool, I'll take this up!

hey @usmanmuhd - it looks like you stopped work, are you still working on this?

@frankchen07 I am interested in doing this, but I have 2 other issues of high priority currently going on. Will take this up once I complete those 2.

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

If it's the former - > create a super user (admin) in django and visit the email url defined urls.py and login as the super user

@thelostone-mc When I go to the urls defined, it redirects me to a google doc link.
When I run docker-compose up and navigate to localhost:8000/explorer it gives me error. Corresponding logs: https://pastebin.com/s0QM5kZ3

eb_1      | django.db.utils.ProgrammingError: relation "dashboard_searchhistory" does not exist
web_1      | LINE 1: ...ata", "dashboard_searchhistory"."ip_address" FROM "dashboard..

you need to run migrations ./manage.py migrate

I am getting this error when I go to http://localhost:8000/_administration/email/quarterly_roundup. https://pastebin.com/anJFNsbW PS: When I comment the line 219 and assign it to zero it displays a page.

In this issue am I supposed to convert all the css to mobile first and then check with the media queries and apply accordingly for larger screens?

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Hey @thelostone-mc bumping this based on @usmanmuhd's question, any thoughts here?

@usmanmuhd Ah sorry man ! I'm running on behing on my github notifications
Ideally since this just a FE task -> you can go ahead and hardcode the variables

updating the following should be enough to get the tempalte running.
bounties_completion_percent = (num_completed_bounties / 1) * 100
largest_bounty_value = 0

The end state would be that email shouldn't break on phone / tablets / monitors ( the latter two are already fine)

Just set those two and I was able to get the following

screencapture-localhost-8000-_administration-email-quarterly_roundup-2018-11-23-19_24_22

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@usmanmuhd due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@usmanmuhd does the ^ help?

@PixelantDesign are we still doing this task? Or should @owocki pull back the funds for it?

Issue Status: 1. Open 2. Cancelled


__The funding of 0.1 ETH (12.79 USD @ $127.88/ETH) attached to this issue has been cancelled by the bounty submitter__

Was this page helpful?
0 / 5 - 0 ratings

Related issues

frankchen07 picture frankchen07  Â·  4Comments

Skyge picture Skyge  Â·  3Comments

wizzfile picture wizzfile  Â·  3Comments

abitrolly picture abitrolly  Â·  4Comments

kziemianek picture kziemianek  Â·  3Comments