Web: Code-cleanup Flake8

[CuriousLearner]

User Story

As a developer, I want a clean code base where flake8 is followed.

Why Is this Needed?

Summary: Better code standard will promote readability and attract new contributors to the project.

Description

Type: STYLING

Current Behavior

flake8 currently fails on the codebase

Expected Behavior

flake8 should pass

Reproduction

Solution

Summary:
Fix linting errors

Definition of Done

• flake8 should pass the entire codebase
• integrate flake8 with Travis to take care in further builds

Additional Information

[mbeacom]

I agree with this, but due to the amount of open work on the platform, we're intentionally not linting the whole codebase to avoid unnecessary stress for fellow community contributors.

We plan to slowly lint each app as the opportunity presents itself and specifically enforce linting on apps that have already been migrated.

[CuriousLearner]

Sure, that makes sense. I'd lint if I touch any files :)

[mbeacom]

I typically make minor adjustments as I'm changing things as well. I just don't want to overwhelm would-be contributors if they have something they're working on in a PR/fork when they try to rebase with the linting changes.

[kuhnchris]

Did you ever send in a PR @CuriousLearner ?

[CuriousLearner]

@kuhnchris Nope. I feel maintainers are inclined towards incremental changes ( which makes sense) fixing these linting errors, so I do not wanted to work on a humongous PR which will be left hanging.

So, I'm not sure if a single PR fixing all this would help 🤷‍♂

[kuhnchris]

Well, I guess we'll have to ask @danlipert or @owocki for a decision on that.

[CuriousLearner]

Cool, let me know if you need a helping hand ;)

[kuhnchris]

Guess that's a no, thanks for offering your help tho @CuriousLearner !