Web: Price fluctuates on the explorer stats page

[owocki]

The stats on this (the USD amounts) should not fluctuate. It should lock in at the time in which the issue was submitted to the blockchain.

[mkosowsk]

Great idea!

Whoever thought of this one is really on top of their game

[owocki]

sry @mkosowsk i should have given you credit. brain fart

[mkosowsk]

No worries! You'll never have need to promote me because I'll always make sure to do it myself haha 😂🤣

[owocki]

possible dupe with https://github.com/gitcoinco/web/issues/693#issuecomment-378514081

[owocki]

hey @PixelantDesign @mkosowsk -- @cryptomental and i are wrapping up some changes on the code here. which prices do we want to show for each individual bounty on the explorer page?

for open (started, submitted) bounties, im thinking we show the CURRENT value of the bounty.
for closed (done, expired, cancelled) bounties, im thinking we show the historical value of the bounty.

does that work?

[PixelantDesign]

Makes sense to me!

[mkosowsk]

@owocki sounds good! One minor clarifying question, for closed when you say historical value of the bounty does that mean when the bounty was first issued or when the bounty was done?

For expired and cancelled, think it might make sense to have the historical value be when the bounty was first issued. But for issues that are done, it might make sense to be the value in fiat that was paid out when the PR was accepted 🤔

In the first case of expired and cancelled, this was the amount in fiat that the Funder wanted to pay out. In the case of when the issue is done, this is the amount that the Contributor actually received. If it's not super complex to differentiate these I think it's worth it

[owocki]

stats with the requested changes -- local vs prod!

One minor clarifying question, for closed when you say historical value of the bounty does that mean when the bounty was first issued or when the bounty was done?

last mutation of the bounty.. so for done, when it became done.. or for cancelled, when it was cancelled

[mkosowsk]

Great work @owocki and @CryptoMental! Think is a pretty big QoL change for Gitcoin, quantifies the real value transfer on the platform and not daily fluctuations in the crypto market 💪🏻🤠👍🏻

[owocki]

one thing i'm noticing from testing.. do we want to show the conv rate date on this module in addition to the conv rate ? if you look at old bounties, the user is kind of left guessing when the conv rate is pegged to.. or maybe i just am because im focused on this now

[mkosowsk]

@owocki I would include the date, think it's good info that provides context

[owocki]

screenshot

[owocki]

https://github.com/gitcoinco/web/pull/853 is live now