Web: Create baseof.html-template

[olafghanizadeh]

I've been examining the codebase a bit and there seems to quite a bit of repetitive code in places. I suggest creating a baseof.html-template, similar to gohugo.io theming, if anyone is familiar with it:

Here is an example:
https://github.com/indigotree/atlas/blob/master/layouts/_default/baseof.html

[owocki]

this is a good idea

[chiptus]

anyone working on it? I started creating something, seems like a big issue, but will have a try

[owocki]

no one is working on it no. still think its a good idea, but we've got a few branches in progress so i worry about the merge conflicts

[chiptus]

I'll start.
What do you think about separating it to PR based on modules? I can start with folders that are less worked on. I started the work on on app/dashboard/templates/bounty so I'll finish that. Each module will have its own baseof.html template. than the parent module can have a baseof template that all other modules will extend.

Does that sound good?

[thelostone-mc]

@chiptus Yeah I'd be okay with that ! 👍
Smal PRs -> easier to review and less buggy

[chiptus]

Can anyone review this, just to say if it's the correct direction, so I can continue?

[thelostone-mc]

@chiptus it looks good to me !
cc @pinkiebell / @SaptakS

leave a ping when it's good for final review ^_^

[chiptus]

Cool, so I will merge develop into my branch and will remove the WIP title.

Feel free to review for releasing to develop.

On Sun, Oct 21, 2018, 01:25 Aditya Anand M C [e-mail]
wrote:

@chiptus https://github.com/chiptus it looks good to me ! ^_^
cc @pinkiebell https://github.com/pinkiebell / @SaptakS
https://github.com/SaptakS

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gitcoinco/web/issues/194#issuecomment-431622675, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABUVF9y8EuL-qn-aHwNXJEMk1wZDxbSRks5um6LcgaJpZM4RPYb0
.

[pinkiebell]

@chiptus
As long there are no conflicts, you can just remove the WIP title.
If there are conflicts, just rebase to master 👍

[kuhnchris]

I assume this was before the rehaul of the UX, correct? I assume since the connected PR is merged that we can close this issue.