Web: Missleading button "Accept/reject claim" for non founder of the issue
After claim to a issue and later check the issue page. The website shows a button "accept/reject" issue. However, is not the owner of the issue. Besides, if you click the button, it shows tabs for creating a issue, which is meant for the founder of the issue to accept or reject the claim.
ernaneluis
All 8 comments
more generally, i feel strongly that the funded issue detail page should only present to users actions that are enabled for them specifically
owocki
on 5 Dec 2017
Yes I agree with you.
ernaneluis
on 5 Dec 2017
posting a bounty for this. requirements
- no button shall appear under the 'funding amount: xxx ETH yyy USD' area unless it is actoinable be the user
- includes but this is not an exhaustive list:
- clawback funds
- accept/reject
- claim issue
etc
this is where the buttons are generated on the JS https://github.com/gitcoinco/web/blob/master/app/assets/v2/js/pages/bounty_details.js#L317-L376
owocki
on 12 Dec 2017
I would like to take this bounty once it gets posted live, @owocki.
tra38
on 12 Dec 2017
@tra38 am waiting for this issue to be turned around https://github.com/MetaMask/metamask-extension/issues/2736 -- the service relies upon metamask/infura, so i can't reliably post a bounty until thats fixed.
you can go ahead and get started @tra38 -- i will just tip you directly when its done. how does 0.05 ETH sound? can you submit a PR back to the repo in some reasonable amount of time, say the next 3 days?
owocki
on 12 Dec 2017
0.05 ETH sounds good to me. 3 days sounds like a reasonable deadline as well.
tra38
on 13 Dec 2017
鈿★笍 A tip worth 0.06 ETH ($41.03) has been granted to @tra38 for this issue. 鈿★笍
The sender had the following public comments:
this is a good fix for the ui of bounty details page!
Nice work @tra38, check your email for further instructions.
- $10396.19 in Funded OSS Work Available at: https://gitcoin.co/explorer
- Incentivize contributions to your repo: Send a Tip or Fund a PR
- No Email? Get help on the Gitcoin Slack
gitcoinbot
on 17 Dec 2017
__The funding of 0.07 ETH (55.78 USD) attached to this issue has been approved & issued .__
- Learn more at on the gitcoin issue page
- Questions? Get help on the Gitcoin Slack
- $12490.72 more Funded OSS Work Available at: https://gitcoin.co/explorer
gitcoinbot
on 21 Dec 2017
Related issues
Skyge
路
3Comments
kuhnchris
路
4Comments
wizzfile
路
3Comments
abitrolly
路
4Comments
pelsasser
路
4Comments
Most helpful comment
@tra38 am waiting for this issue to be turned around https://github.com/MetaMask/metamask-extension/issues/2736 -- the service relies upon metamask/infura, so i can't reliably post a bounty until thats fixed.
you can go ahead and get started @tra38 -- i will just tip you directly when its done. how does
0.05 ETHsound? can you submit a PR back to the repo in some reasonable amount of time, say the next 3 days?