Web-stories-wp: AMP Sanitization breaks gradients (again)

Created on 30 Oct 2020  路  2Comments  路  Source: google/web-stories-wp

Bug Description

This is essentially #4529, but now the other way around:

When _not_ using the AMP plugin, gradients will be stripped on the frontend.

The reason is a bug in PHP-CSS-Parser, which the AMP plugin solves by patching the package.

Since we cannot just let the AMP plugin deal with the patches because of https://github.com/cweagans/composer-patches/issues/315, we copied all the patches to our repo.

However, the patches section was accidentally omitted.

But even with that set I'm currently getting issues with patches not applying cleanly.

So this needs some investigation.

Expected Behaviour

PHP-CSS-Parser patches should be applied cleanly.

Steps to Reproduce

  1. Apply gradient to element
  2. Notice that gradient disappears on frontend.

Workaround: install AMP plugin.

Screenshots

Additional Context

  • Plugin Version: 1.1.0
  • Operating System: macOS
  • Browser: Chrome 86

_Do not alter or remove anything below. The following sections will be managed by moderators only._

Acceptance Criteria

Implementation Brief

AMP Output P0 WP & Infra Bug Infrastructure Passed

All 2 comments

Verified in QA

FE - radial and liner:
image.png

I see beautiful gradients! image.png

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ernee picture ernee  路  4Comments

injainja picture injainja  路  4Comments

netnaps picture netnaps  路  3Comments

3pgarro picture 3pgarro  路  4Comments

o-fernandez picture o-fernandez  路  3Comments