Web-stories-wp: Bold not displayed right away while in edit mode

Created on 3 Apr 2020  路  6Comments  路  Source: google/web-stories-wp

Bug Description

Toggling bold while the Text is in edit mode doesn't have an instant effect while the italic and underline have.

After exiting the edit mode, bold is shown.

Expected Behaviour


Bold should take effect right away in edit mode, the same way as italic and underline do, otherwise, it feels broken.

Steps to Reproduce

  1. Add Text
  2. Go to edit mode
  3. Toggle Bold.

Screenshots

bold


_Do not alter or remove anything below. The following sections will be managed by moderators only._

Acceptance Criteria

QA Instructions

Text P0 Bug

Most helpful comment

Indeed, it's not related to #922 . It's not working because we only set the bold boolean state in the initial state without any further tracker of changes.

All 6 comments

Fixed by #992? Se #922.

992 seems to be related to output, this issue is just the bold effect not showing right away when toggling in the editor. Will try to create a gif.

Edit: Added under screenshots!

I noticed that if you make some bold, it can remain bolded and I cant unbold it.

Indeed, it's not related to #922 . It's not working because we only set the bold boolean state in the initial state without any further tracker of changes.

This will be fixed by major rewrite to be done in #413.

Will assign this to @barklund and move to "In Progress" as it'll get fixed by #1323 (for clarity on the board)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

injainja picture injainja  路  4Comments

obetomuniz picture obetomuniz  路  3Comments

jauyong picture jauyong  路  4Comments

injainja picture injainja  路  4Comments

o-fernandez picture o-fernandez  路  3Comments