Web-bugs: help.uber.com - see bug description

[webcompat-bot]

URL: https://help.uber.com/h/6949160d-3eb6-42cd-8155-1ae3cf25be0b
Browser / Version: Firefox 51.0
Operating System: Ubuntu
Problem type: Something else - I'll add details below

Steps to Reproduce

1. Navigate to: https://help.uber.com/h/6949160d-3eb6-42cd-8155-1ae3cf25be0b
2. Click "I FORGOT MY PASSWORD"

Expected Behavior: Link goes to password reset page https://auth.uber.com/login/forgot-password

Actual Behavior:
Nothing happens. Reproducible in regular and Private browsing modes.
https://help.uber.com/h/24a8fa5a-59b0-49b8-81e9-13e6dff81a1b has the same issue with "RECOVER MY PASSWORD"

_From webcompat.com with ❤️_

[adamopenweb]

Thanks for the report! I can reproduce this issue in Firefox 54 for OSX.

We get a lot of errors in the console, but we the same messages in Chrome where the link works.

Strict-Transport-Security: The site specified a header that could not be parsed successfully.[Learn More]
6949160d-3eb6-42cd-8155-1ae3cf25be0b
extension loaded
utag.js:99:1
window.utag_data.eventName is undefined
utag.557.js:7:1
window.utag_data.eventType is undefined
utag.557.js:7:74
a is view
utag.557.js:7:147

...cut for length

<button class="cta-link  _style_3M1aDH" ... cut for length ...>

  <div class="text--none display--inline-block" data-reactid=".0.1.5.0.0.1.$6949160d-3eb6-42cd-8155-1ae3cf25be0b.1.0.$263ad101-7499-46ed-873a-92f6881e17eb.0.0">

    <a href="https://auth.uber.com/login/forgot-password" class="" data-reactid=".0.1.5.0.0.1.$6949160d-3eb6-42cd-8155-1ae3cf25be0b.1.0.$263ad101-7499-46ed-873a-92f6881e17eb.0.0.0">I FORGOT MY PASSWORD</a>

    <div class="cta-link__underline" data-reactid=".0.1.5.0.0.1.$6949160d-3eb6-42cd-8155-1ae3cf25be0b.1.0.$263ad101-7499-46ed-873a-92f6881e17eb.0.0.1">
    </div>
  </div>

  <svg> ... cut for length ....</svg>
</button>

I think the issue is caused by the anchor element being nested inside of the button. If we change the button to a div, the link works as expected.

@wisniewskit anything I missed here? Should we set to needscontact?

[wisniewskit]

@adamopenweb, no, I think you're right on with the assessment. Nesting interactive elements like that is unwise; it's non-standard and won't work on all browsers (and can also even work strangely in the ones where it seems to work).

[karlcow]

Isn't that another case of https://bugzilla.mozilla.org/show_bug.cgi?id=1089326
That we see also in #3575
See my comment on https://bugzilla.mozilla.org/show_bug.cgi?id=1089326#c44

[karlcow]

So @uber has a lot of people on github https://github.com/orgs/uber/people
@akre54 would you know who is in charge of the front-end of help.uber.com
so we can solve this issue and makes it work on Firefox.

[akre54]

I pinged some folks, someone should take a look at this soon. Thanks for reporting.

[rhobot]

Engineers are working on it. Thank you for reporting!

[karlcow]

Thanks everyone.

[samueljun]

Deployed the fix! Let me know if you're still seeing this issue

[karlcow]

This is working. Closing as fixed with one of the fastest resolutions.
Thanks a lot.

[karlcow]

Duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1397981