Weasyprint: Fix tests with Pango 1.44

[liZe]

Pango 1.44 has been released with a lot of changes that break 13 tests (same results on Linux and macOS, that's good news).

[liZe]

Cairo 1.17.2 breaks 2 other tests.

[liZe]

Cairo 1.17.2 seems to be broken in many ways, let's wait for a more stable snapshot.

[liZe]

The fix in d6da699 is not really good, it's just a workaround. As it breaks one test with the previous versions of Pango, and as this test is not a corner case, I have to find a better fix.

[Tontyna]

Why bother with a fix for a broken Pango patch version? Will Pango 1.44.3 be widespread and last for long?

[liZe]

Why bother with a fix for a broken Pango patch version? Will Pango 1.44.3 be widespread and last for long?

The fixes are for 1.44.x, not for 1.44.3 only (do you really think I'm such a masochist?). There's no workaround in d6da699 for 1.44.3's bug, we'll wait for 1.44.4 to have tests passing.

But the way line heights are calculated in Pango 1.44.x really breaks WeasyPrint rendering, that's what we have to fix.

[Tontyna]

do you really think I'm such a masochist?

Of course you are -- it's Saturday! No sane person ever looks after stupid software on weekends

[Tontyna]

aab0fa5 is definitely much healthier than d6da699

[liZe]

aab0fa5 is definitely much healthier than d6da699

It is.

[liZe]

The last failing test is fixed in Pango 1.44.4, that has been released (and works for me) but not packaged yet in Homebrew.

[Tontyna]

MSYS2 is still with Pango 1.43.0 .
There's even a (recent) comment in their PKGBUILD file:

# Don't update to 1.44.0! https://gitlab.gnome.org/GNOME/pango/issues/385

[liZe]

:tada: https://travis-ci.org/Kozea/WeasyPrint/builds/572272435 :tada:

MSYS2 is still with Pango 1.43.0 .
There's even a (recent) comment in their PKGBUILD file:

# Don't update to 1.44.0! https://gitlab.gnome.org/GNOME/pango/issues/385

This issue is fixed now, with a couple of "bad" changes they tried to include and that have been reverted now. These two blog entries (1, 2) are really interesting to understand their choices. We can expect other big changes in the future months, but I'm pretty confident, they know what they're doing.

Cairo 1.17.2 seems to be broken in many ways, let's wait for a more stable snapshot.

This is just a dev snapshot, and they've tried hard to separate stable from unstable releases since 1.16.0, so we can wait a little bit more. My computer was barely usable with it… And I'm not the only one hoping for more regular releases, even Behdad Esfahbod is fed up with that.