Waterfox: 🐞 Waterfox Issue List Tracker

Created on 25 Apr 2018  ·  46Comments  ·  Source: MrAlex94/Waterfox

_Hey there!_

_This is a list of Waterfox bugs yet unresolved. No guarantee for completeness. Should some of them be resolved by now, feel free to inform me. I will delete the corresponding entries in this case. This issue was created in an attempt to create an overview and as a potential starting point for sorting them out._

Waterfox General

Waterfox Classic

Waterfox Current

  • [x] Separate out australis theme
  • [x] Fix loading of all NPAPI plugins

Features to keep

Issues that are planning to be deprecated by Mozilla, but will be kept by Waterfox

ALREADY FIXED / NOT AN ISSUE ANYMORE:

Most helpful comment

Should I begin adding other open issues?

All 46 comments

Don't expose navigator.AddonManager to content
-> #204

https://github.com/MrAlex94/Waterfox/pull/449

@laniakea64

449

Scratched from the list. What about the rest?

idk about all of the rest. The ones I reported are still unresolved, the resource URI leak is still unresolved, and I think most of the others are still unresolved too.

Not sure about this one though -

Ubuntu 17.04 mozconfig redirection error
-> #227

Will comment in that issue.

Thanks for this list - it's actually quite helpful. I've started going through all the issues and patching them. If you guys can do local builds as well to test I'm not breaking anything, that would be appreciated 😄. I've been doing them myself and they're fine, but that's not too great of a test range as there are so many different configurations out in the wild.

@Peacock365 Should https://github.com/MrAlex94/Waterfox/issues/534 be added to this list?

Thanks for working on the regressions, @MrAlex94

404 doesn't seem to be fixable without major code rewrites, I have noticed. Even the current Firefox at times still has this problem.

416 seems to be fixable via https://github.com/mozilla/gecko-dev/commit/6b36043a0db3

422 seems to be fixable via https://github.com/MoonchildProductions/Pale-Moon/commit/6d773b16968b50c848083382b03bd99727c08f41

URGENT!!!!!!! Resource leak
-> #235

Seems fixed in self build from https://github.com/MrAlex94/Waterfox/commit/d5c25411b0838a4578f8a96aa2e09568d900e9b6 👍

Zoom-in/Zoom-out mouse cursors don't display
-> #347

Fixed by https://github.com/MrAlex94/Waterfox/commit/d5c25411b0838a4578f8a96aa2e09568d900e9b6

@laniakea64

I updated the list to reflect the fixes for #235 and #347 Thanks for the update.

464 and #282 and #482 seem fixed, too.

Adobe Flash Player 28.0.0.126 can not present its context menu, crashes, with Waterfox 56.0.1 on Linux · Issue #335 …

I could probably add a few more – I occasionally review issues in chronological order, or least recently updated – but I'm wary of this issue becoming too long (for me) to absorb. YMMV

… local builds as well to test I'm not breaking anything, …

Linux users: how are builds for you?

(On FreeBSD-CURRENT, an attempt to build 56.1.0_18 fails at audio/alsa-lib 1.1.2_1. I can probably _might_ work around it reasonably easily (https://redd.it/8gk2v3), I don't know whether things will be as easy in Linux environments.)

Linux users: how are builds for you?

Working well for me.

@laniakea64

Would it be possible to create commits for the two issues I pointed to above the first @grahamperrin comment? After all, the code that fixes these is already out there (I linked to it in both cases)...

I don't have time to do more pull requests atm and I'm likely not the right person to do those anyway. #166 is Windows-specific and I only have Linux; I can't reproduce #416; and I don't understand the code related to #422 well enough.

@MrAlex94

Here is the list of known fixes again (so that it does not get buried in the thread):

416 can be fixed via https://github.com/mozilla/gecko-dev/commit/6b36043a0db3 (see also @jbeich comment in the issue)

422 can be fixed via https://github.com/MoonchildProductions/Pale-Moon/commit/6d773b16968b50c848083382b03bd99727c08f41

350 can be fixed via https://bazaar.launchpad.net/%7Emozillateam/firefox/firefox.trusty/view/1200/debian/patches/unity-menubar.patch

414 can be fixed via:

515 can be fixed via:

_devtools.webide.enabled_ - false
_devtools.webide.autoinstallADBHelper_ - false
_devtools.webide.autoinstallFxdtAdapters_ - false
_devtools.webide.autoConnectRuntime_ - false

387 and #405 seem like trivial, cosmetical fixes.

166 won't be fixed with just that patch. And regardless, just reverting one patch when a whole lot has changed in the Chromium IPC is such a terrible idea. I'm not sure at this stage if it's worth supporting Vista or lower, as Mozilla have made good performance and security updates due to removing legacy support for those platforms.

350 isn't going to be merged in. Isn't Unity effectively abandoned since the release of Ubuntu 18.04 LTS?

Well, in this case I think you can close issue #166 ... I see your reasoning for this one.

With #350 I wouldn't be so sure, as two older LTS versions are still supported and as all versions prior to Ubuntu 18.04 had unity. It's up to you, but I don't really see a reason here not to merge it. Let's not forget that Ubuntu 16.04 will receive updates until 2021, so it is well worth to patch the issue for that version alone.

Anyway, I hope the rest is helpful regardless.

-> #357

Duplicate of about:addons 'Check to see if your plugins are up to date' · Issue #336 …

I just noticed that @MrAlex94 mentioned additional bugs that he wanted to fix here:

https://blog.waterfoxproject.org/waterfox-56.0-release-download (Under "_What's due in Q1 2018?_")

Well, I have found a potential fix for the XML Buffer Overflow Crash (_Bug 485941_):
-> https://bugzilla.mozilla.org/show_bug.cgi?id=485941
-> FIX: https://bugzilla.mozilla.org/attachment.cgi?id=8901555&action=diff

Furthermore, @MrAlex94 mentioned _Bug 895096_ (inconsistent widths of border-collapsed table borders), for this one there are fixes as well:
-> https://bugzilla.mozilla.org/show_bug.cgi?id=895096
-> FIXES:

A font settings issue was brought up here:
-> https://www.reddit.com/r/waterfox/comments/7q50r9/it_seems_like_font_settings_are_erroneously/?st=JCQZQ5DB&sh=fb9aa53a
This thread suggested the following bug as the culprit, but this is somewhat wrong (this bug was fixed in Firefox / Waterfox 41.0):
https://bugzilla.mozilla.org/show_bug.cgi?id=789788
Instead, the culprit seems to be this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1430798
_Bug 1430798_ seems to be related to something being mishandled by the fix for _Bug 789788_ though. See Jonathan Kew's reply in _Bug 1430798_ for more info.

So I'm focusing on getting all the security patches done, then will revisit this after.

433 is fixed. EDIT: Fix reverted as insufficient.

Could you maybe add a checklist to the issue description? That way it might be easier to track the status how many issues are already resolved. :)
(See GitHub Help: About task lists)

Should I begin adding other open issues?

@criztovyl

Sure, I did just set one up now.

@grahamperrin

Feel free to do so. The two criterions I used to track "real" issues down are as follows:

1) The issue is not add-on related (in which case the add-on dev would be the one to approach).
2) The issue is present on a platform Waterfox actually supports (e.g. XP/Vista problems are WONTFIX by default).

I think those two criterions make sense. I am anticipating your further entries.

Thank you! :)

OK, here goes.

E&OE, and if you have any comment on an issue, please aim to make the comment _in_ the issue.

Thanks …

203 and #296 are duplicates, they also duplicate _Bug 606655_ mentioned here: https://blog.waterfoxproject.org/waterfox-56.0-release-download -> All this is going to be fixed once @MrAlex94 reintroduces the cookie prompt.

411 is an intentional removal due to PIDs confusing some users. WONTFIX

383 and #384 and #363 all deal with the same issue.

370 is already fixed (the preference shows true again by default).

399 and #400 are going to be fixed soon, and so is #548 as a whole. See Toromino's comment in #548. I am optimistic that a fitting patch will be surfacing soon.

419 is fixed already, as the Waterfox 56.1 release notes state (WF 56.1 simultaneously fixes 10.8 of course):

OS X 10.7 support is now properly back.

source: https://blog.waterfoxproject.org/waterfox-56.1.0-release-download

380 could already have been fixed by Waterfox 56.1.0:

You can now Refresh your profile at about:support!

source: https://blog.waterfoxproject.org/waterfox-56.1.0-release-download

304 could be fixed by disabling Stylo on the platform. Possibly disabling it on OS X 10.8 as well.

560 would require Firefox 57+ WebExtension APIs to be backported to Waterfox 56.

Thanks, can you comment in issues? So that subscribers can be more immediately aware.

NB I don't treat an issue as resolved whilst it's open. Some of the green badges above will turn red reasonably soon.

@MrAlex94 re: your https://github.com/MrAlex94/Waterfox/issues/538#event-1603332630 would you like this meta issue to also track enhancement requests (ERs) that are will be may be actionable? E.g. if people contribute PRs.

I see the three that are labelled _enhancement_, plus probably one more.

@grahamperrin

I can't speak for @MrAlex94 of course, yet personally I would refrain from doing so. Look at how little progress we have made here so far. I understand that @MrAlex94 has other important priorities (e.g. merging in security updates), but it is still beyond me how trivial fixes like those for #422, #564, #515 aren't merged in in a more timely manner. With all due respect.

I viewed this list as primarily for _tracking_ …

… not for _prioritising_, although I understand why some people might want to use the list in that way.

We have, for example, a non-bug issue that "is coming …" (is _unresolved_) but not yet listed.

Prioritising and scheduling

Ideals, in the context of GitHub, should be labels and milestones.

I see good use of priority labels in repos such as Mozilla's _Activity Stream_. For example:

Note, that's not to suggest that Alex should (or must) begin doing more with labels;

if not very carefully planned – and if not applied with consistency – things such as labels can make it more difficult to find what's required, especially when a repository becomes relatively busy.

357 was closed

but it's actually a duplicate of #336
(not tagged as duplicate)

227 was closed

issue #962 added for another webextension causing delazification issues in Waterfox

@Squall-Leonhart commented on 2019. máj. 12. 04:04 CEST:

issue #962 added for another webextension causing delazification issues in Waterfox

The MyJDownloader Browser Extension is also one of them.

Waterfox lacks obligatory legal information #1021 needs to be added to this. It's such an easy fix to add the source link to about:buildconfig to comply with Mozillas license.

@troysjanda thanks, and https://github.com/MrAlex94/Waterfox/issues/538#issuecomment-389295921

if you have any comment on an issue, please aim to make the comment _in_ the issue.

Okay have updated the list and re-organised it a bit. Shame I can't take over issues so @Peacock365 doesn't get bombarded with notifications :-)

expect a new current build soon?

Couple things to consider adding to the list of Waterfox Current specific issues? -

1) It is still impossible to do a stock Waterfox Current build on Linux. I still use these mozconfig customisations to unbreak building - https://github.com/MrAlex94/Waterfox/issues/944#issuecomment-526942809

2) Quoting @Peacock365 -

_security.family_safety.mode_ must be set to 0, in order to fend off potential issues due to local Man in the middle setups. See the Pale Moon 28.4.1 release notes, too: https://www.palemoon.org/releasenotes-archived.shtml Waterfox 56 had this set to 0 as well, as opposed to Firefox where this has been set to 2 since Firefox 52.

I'm not able to create pull requests for these issues, since:

  • regarding (1), I have no way to tell whether any fix I use would be too specific to my build environment,
  • regarding (2), although I do see that pref at default value of 2, I'm on Linux and that only applies to Windows.

Couple things to consider adding to the list of Waterfox Current specific issues? -

1. It is still impossible to do a stock Waterfox Current build on Linux.  I still use these mozconfig customisations to unbreak building - [#944 (comment)](https://github.com/MrAlex94/Waterfox/issues/944#issuecomment-526942809)

2. Quoting @Peacock365 -

_security.family_safety.mode_ must be set to 0, in order to fend off potential issues due to local Man in the middle setups. See the Pale Moon 28.4.1 release notes, too: https://www.palemoon.org/releasenotes-archived.shtml Waterfox 56 had this set to 0 as well, as opposed to Firefox where this has been set to 2 since Firefox 52.

I'm not able to create pull requests for these issues, since:

* regarding (1), I have no way to tell whether any fix I use would be too specific to my build environment,

* regarding (2), although I do see that pref at default value of `2`, I'm on Linux and that only applies to Windows.

Hmm, I can seem to build with the current .mozconfig, maybe I've got a local change or ENV variable set. I will double check

Curious, will there be a new Current build soon? Not being pushy just saw that Classic was updated but no Current build.

This is issue has been closed and replaced with this issue, since GitHub does not allow changing ownership of issues.

Was this page helpful?
0 / 5 - 0 ratings