Watchtower: Don't add timestamps to shoutrrr notifications

Created on 12 Apr 2020  路  5Comments  路  Source: containrrr/watchtower

One feature I鈥檓 missing while testing the new notifications on latest-dev is to disable the timestamps. Since I think most of the services show timestamps anyway, I think there should be an option to disable and/or format them in watchtower.

_Originally posted by @mbrandau in https://github.com/containrrr/watchtower/issues/264#issuecomment-612574815_

Medium Available Enhancement

Most helpful comment

I'd say it's ok to just remove it, as none of the legacy notification services have it.

The SMTP legacy service also shows timestamps and log levels. (I copied that function from there)

I'm gonna put up a PR that removes the timestamps from Shoutrrr notifications but adds a flag to optionally enable showing log levels.

All 5 comments

Also I think there should be an option to disable the log level too.

What would be your preferred way to fix this?

  1. Add flags like --notificationsShowTimestamps=false --notificationsShowLevel=false (IMHO not showing these should be the default)
  2. Generally remove them
  3. ?

Where to fix this: https://github.com/containrrr/watchtower/blob/1fad78799f96736da00c95d271ff8fe8f2199cfe/pkg/notifications/shoutrrr.go#L44

I'd say it's ok to just remove it, as none of the legacy notification services have it.

--notifications-show-level would be more in line with the other flags, but other than that - all for. defaulting to off seems reasonable as well.

I'd say it's ok to just remove it, as none of the legacy notification services have it.

The SMTP legacy service also shows timestamps and log levels. (I copied that function from there)

I'm gonna put up a PR that removes the timestamps from Shoutrrr notifications but adds a flag to optionally enable showing log levels.

To avoid important communication to get lost in a closed issues no one monitors, I'll go ahead and lock this issue. If you want to continue the discussion, please open a new issue. Thank you! 馃檹馃徏

Was this page helpful?
0 / 5 - 0 ratings

Related issues

eloo picture eloo  路  5Comments

7imbrook picture 7imbrook  路  7Comments

michael-siebers picture michael-siebers  路  5Comments

ag0r4n picture ag0r4n  路  4Comments

meandthedevil picture meandthedevil  路  6Comments