Warehouse: Do not show 'view project' button when there are no releases

Created on 27 Feb 2018  路  4Comments  路  Source: pypa/warehouse

Steps to reproduce

  • Login as a package maintainer
  • Go to the projects page
  • Click on a project
  • Delete all releases on the project

What happens

The project card at the top of the page shows a 'view project' button:

screenshot from 2018-02-27 08-25-55

What should happen

The 'view project' button at the top of the page should not show if there is no release.

Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, please work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, please feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.

bug good first issue raised in user testing

Most helpful comment

I think I would prefer if this button was disabled w/ a tooltip, not hidden, as it might not be immediately obvious to a user why the button is present for some projects and not present for others.

@nlhkabu Thoughts?

All 4 comments

I think I would prefer if this button was disabled w/ a tooltip, not hidden, as it might not be immediately obvious to a user why the button is present for some projects and not present for others.

@nlhkabu Thoughts?

@nlhkabu I agree with @di who said,

I think I would prefer if this button was disabled w/ a tooltip, not hidden, as it might not be immediately obvious to a user why the button is present for some projects and not present for others.

so please consider reopening this to add that.

Hmm, I seemed to have merged https://github.com/pypa/warehouse/issues/3257, this might have been my fault.

Nope, we can leave it closed. User testing suggested the button was confusing, so removing it altogether is a better solution :)

Was this page helpful?
0 / 5 - 0 ratings