Walletwasabi: Remove CLI interface

[molnard]

This change started a conversation among @nopara73 and me. The CLI functions are hard/impossible to use by normal users - so they should be moved to UI. Not mentioning the code would be simplified a lot.

What will change?

Changing the project type from Console Application to Window application

• In release mode, there won't be a console window.
• In release mode, there won't be any console messages even when running from the console.
• Input arguments will still possible to use.

Todo

• [x] Remove console window in Release mode https://github.com/zkSNACKs/WalletWasabi/pull/4911
• [x] Remove NSubsys https://github.com/zkSNACKs/WalletWasabi/pull/4913
• [x] Test packager and test release on all OSs https://github.com/zkSNACKs/WalletWasabi/pull/4913
  
  
  
  • win: console output is empty even running from Terminal
  
  
  • macOS: console output still there if you run from Terminal
  
  
  • linux: console output still there if you run from Terminal
  
  
• [x] Move/Remove PasswordFinder to UI https://github.com/zkSNACKs/WalletWasabi/pull/4960
• [ ] Remove daemon code
• [x] Remove current command interpreter code https://github.com/zkSNACKs/WalletWasabi/pull/4962
• [x] Add Crash report functionality https://github.com/zkSNACKs/WalletWasabi/pull/4917
• [ ] Implement all daemon functionality to UI
  
  
  
  • [ ] Mix wallet
  
  
  • [ ] Mix to another wallet
  
  
  • [ ] Keepalive - automixing
  
  

[lontivero]

Concept ACK.
Suggestion: remove the PasswordFinder completely.

[molnard]

Concept ACK.
Suggestion: remove the PasswordFinder completely.

It saved many users' lives. Just remove it or there will be an alternative?

[lontivero]

Next release will ask users to confirm theirs passwords and that will remove the chances to typos.

[molnard]

We agreed to remove the PW finder, in the new UI the users have to verify their entered password before successfully creating a wallet.

[nopara73]

NACK, password finder is important. We should definitely add it to the GUI.