Walletwasabi: C# 9.0 synthetic sugars

[molnard]

Start using the new stuff.

https://devblogs.microsoft.com/dotnet/c-9-0-on-the-record/

First start with the smaller ones, like the not operator https://github.com/zkSNACKs/WalletWasabi/pull/4751

Then later the larger and the controversial ones.

[molnard]

@yahiheb the supported OS versions might change with .NET 5. Can you elaborate on that?

https://docs.microsoft.com/en-us/dotnet/core/install/linux-ubuntu

[yahiheb]

@yahiheb the supported OS versions might change with .NET 5. Can you elaborate on that?

https://github.com/dotnet/core/blob/master/release-notes/5.0/5.0-supported-os.md

.NET 5.0 is supported on:

Windows:

OS | Version
-- | --
Windows 10 | 1607+ (version 1703 is not supported)

Linux:

For the best compatibility, choose a long-term release (LTS) version.

OS | Version
-- | --
Ubuntu | 20.10, 20.04 (LTS), 18.04 (LTS), 16.04 (LTS)
Fedora | 32+
Debian | 9+

macOS:

OS | Version
-- | --
macOS | 10.13+

[molnard]

We have a compatibility doc out there, does it need to be updated? And the website?

[yahiheb]

@molnard

We have a compatibility doc out there, does it need to be updated?

https://github.com/zkSNACKs/WalletWasabi/pull/4768

And the website?

I think we don't need to change anything with the website because we never mentioned the detail of the supported OSs.

[molnard]

dev meeting notes:

• Check new static analyzers, for example, CancellationToken propagation,

[kiminuo]

@molnard @yahiheb https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2016 - This is the rule for CancellationToken propagation I was talking about.

edit: These looks interesting to me too:

• https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2000 - dispose before losing scope
• https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2012 this looks interesting too.
• https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2011

[molnard]

All seems to be useful.